Skip to content

Allow for tolerance specification in domain_boundary_sides() #761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jhabriel merged 3 commits into from
Nov 9, 2022
Merged

Allow for tolerance specification in domain_boundary_sides() #761

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a78a7fd
ENH: Allow passing `tol` in `domain_boundary_sides()`.
jhabriel Nov 8, 2022
4de06f8
DOC: Improve sentence.
jhabriel Nov 8, 2022
240fd86
Merge branch 'develop' into feat_domain_boundary_size
jhabriel Nov 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 28 additions & 14 deletions src/porepy/models/abstract_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,8 +346,10 @@ def _export(self) -> None:
pass

def _domain_boundary_sides(
self, g: pp.Grid
) -> Tuple[
self,
sd: pp.Grid,
tol: float = 1e-10,
) -> tuple[
np.ndarray,
np.ndarray,
np.ndarray,
Expand All @@ -356,24 +358,36 @@ def _domain_boundary_sides(
np.ndarray,
np.ndarray,
]:
"""Obtain indices of the faces of a grid that lie on each side of the domain
boundaries. It is assumed the domain is box shaped.
"""Obtain indices of the faces lying on the sides of the domain boundaries.

The method is primarily intended for box-shaped domains. However, it can also be
applied to non-box-shaped domains (e.g., domains with perturbed boundary nodes)
provided `tol` is tuned accordingly.

Args:
sd: Subdomain grid.
tol: Tolerance used to determine whether a face center lies on a boundary side.

Returns:
Tuple of boolean arrays, each one of size sd.num_faces. For a given array,
a True element indicates that the face lies on the side of the domain.
Otherwise, the element is set to False.

"""
tol = 1e-10
box = self.box
east = g.face_centers[0] > box["xmax"] - tol
west = g.face_centers[0] < box["xmin"] + tol
east = sd.face_centers[0] > box["xmax"] - tol
west = sd.face_centers[0] < box["xmin"] + tol
if self.mdg.dim_max() == 1:
north = np.zeros(g.num_faces, dtype=bool)
north = np.zeros(sd.num_faces, dtype=bool)
south = north.copy()
else:
north = g.face_centers[1] > box["ymax"] - tol
south = g.face_centers[1] < box["ymin"] + tol
north = sd.face_centers[1] > box["ymax"] - tol
south = sd.face_centers[1] < box["ymin"] + tol
if self.mdg.dim_max() < 3:
top = np.zeros(g.num_faces, dtype=bool)
top = np.zeros(sd.num_faces, dtype=bool)
bottom = top.copy()
else:
top = g.face_centers[2] > box["zmax"] - tol
bottom = g.face_centers[2] < box["zmin"] + tol
all_bf = g.get_boundary_faces()
top = sd.face_centers[2] > box["zmax"] - tol
bottom = sd.face_centers[2] < box["zmin"] + tol
all_bf = sd.get_boundary_faces()
return all_bf, east, west, north, south, top, bottom