Skip to content

Commit

Permalink
Fixes to the menus, keyboard accessibility, styles, and adds customiz…
Browse files Browse the repository at this point in the history
…er support
  • Loading branch information
priscillamc committed Apr 26, 2019
1 parent 77bce2c commit 6890b23
Show file tree
Hide file tree
Showing 21 changed files with 1,324 additions and 562 deletions.
12 changes: 8 additions & 4 deletions Gruntfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ module.exports = function(grunt) {
outputStyle: 'compressed'
},
files: {
'./assets/css/inline.min.css': './assets/css/inline.css',
'./style.min.css': './style.css'
}
}
Expand All @@ -28,13 +29,16 @@ module.exports = function(grunt) {
*/
concat: {
options: {
separator: ';\n',
separator: '\n',
sourceMap: true,
sourceMapIncludeSources: true,
sourceMapIn: function(path) { return path + ".map"; }
},
dist: {
src: [
'assets/js/global.min.js',
'assets/js/navigation.min.js',
'assets/js/skip-link-focus-fix.min.js',
'assets/js/navigation.min.js',
'assets/js/global.min.js',
'assets/js/jquery.scrollTo.min.js',
'assets/js/theme.min.js',
],
Expand Down Expand Up @@ -73,7 +77,7 @@ module.exports = function(grunt) {
*/
watch: {
css: {
files: ['./style.css'],
files: ['./style.css', 'assets/css/*.css', '!assets/css/*.min.*'],
tasks: ['sass']
},
js: {
Expand Down
37 changes: 34 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,7 @@ The menu location areas below require a menu:

#### Keyboard Navigation

Users can tab through the links and see a highlight around the linked element.

Elements that cannot be accessed via keyboard (main menu submenus, search).
Keyboard users can use the tab key to navigate through the menus, links, and buttons on the page. Users will see an outline around the current link/element.

### SVG Icons & Images

Expand Down Expand Up @@ -87,5 +85,38 @@ Featured image custom field (caption is a WP field):

- photo_credit_txt

### Stylesheets

Parent theme styles are not used. The theme includes these stylesheets:

- style.min.css - minified child theme styles
- assets/css/inline.min.css - minified inline styles from advancement.clas.ufl.edu (unclear where these styles are used)

The main stylesheet divides the styles into sections with media queries. Since these styles are redefined for each breakpoints instead of overriding previous styles, styles appear multiple times for each breakpoint. This can be solved using cascading, SASS, and using a mobile-first structure.

**Note: When updating any styles, be sure to search and update each breakpoint.**


### JavaScript

The JS files are minified and combined in the main JS file, script.min.js.

Custom JS file:

- theme.js

Modified versions of parent theme files:

- global.js
- jquery.scrollTo.js
- navigation.js
- skip-link-focus-fix.js

Included from the parent theme:

- html5.js





Loading

0 comments on commit 6890b23

Please sign in to comment.