fix file name sanitization for manual theme scan (#88) #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanitize_file() strips all directory separators from the file path that is passed via AJAX. We now simply sanitize the string, as the actual file path is validated during the process anyway.
Codecov Report
@@ Coverage Diff @@
## develop #89 +/- ##
==========================================
Coverage 26.51% 26.51%
Complexity 147 147
==========================================
Files 5 5
Lines 513 513
==========================================
Hits 136 136
Misses 377 377
Continue to review full report at Codecov.
|
# Conflicts: # CHANGELOG.md
patrickrobrecht
approved these changes
Dec 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sanitize_file()strips all directory separators from the file path that is passed via AJAX. We now simply sanitize the string, as the actual file path is validated during the process anyway.fixes #88