Add new formatting options by replacing d3.format method with more recent d3-format module
#5125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool! Does this sidestep the challenges encountered in #5023 ? |
archmoj
force-pushed
the
new-d3-number-format
branch
2 times, most recently
from
9c20e84 to
427e5e3
Compare
archmoj
force-pushed
the
new-d3-number-format
branch
from
427e5e3 to
efaebd7
Compare
archmoj
force-pushed
the
new-d3-number-format
branch
from
efaebd7 to
b59b1fb
Compare
archmoj
force-pushed
the
new-d3-number-format
branch
from
b59b1fb to
fb0e62e
Compare
archmoj
force-pushed
the
new-d3-number-format
branch
from
fb0e62e to
9f51808
Compare
archmoj
force-pushed
the
new-d3-number-format
branch
3 times, most recently
from
9b69f1e to
cd0d392
Compare
- centralize and wrap require d3 format in lib - adjust old and new formats
archmoj
commented
Jul 12, 2021
package.json
Outdated
| }, | ||
| "dependencies": { | ||
| "@plotly/d3": "3.7.0", | ||
| "@plotly/d3": "git://github.com/plotly/d3.git#3fc195e30e85b008238783379d2aa067c737e636", |
archmoj
changed the title
archmoj
changed the title
d3.format method with more recent d3-format module
Co-authored-by: Alex Johnson <[email protected]>
src/lib/index.js
Outdated
| }; | ||
|
|
||
| lib.beginCap = function(str) { | ||
| return str.charAt(0).toUpperCase() + str.slice(1); |
There was a problem hiding this comment.
Lines 723 to 725 in bdb69fc
| Lib.adjustFormat(formatStr) | ||
| ); | ||
| } catch(e) { | ||
| return Lib.noFormat; |
There was a problem hiding this comment.
Is this catching invalid format strings? Do we want to lib.warn when this happens, to help people fix it?
alexcjohnson
approved these changes
Jul 17, 2021
There was a problem hiding this comment.
💃 after those couple of comments and merging/publishing plotly/d3#4
Nice job with lib.adjustFormat!
This was referenced Jul 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to replace old d3 format functions with latest
d3-numbermodule as part of d3 bump cc: #424; while keep trimming the default option which was quite tricky.TODO:
d3.formatfromplotly/d3fork and use it hereAlso to note:
d3.timefromplotly/d3fork and switched tod3-timemodule in dc0d9cb cc: Bumping d3 #424@plotly/plotly_js
PR to help maintain previous behavior: https://github.com/plotly/plotly.js/pull/5820/files
Added new functionalities illustrated in
lib_number_format_test.js785f128Also see extra options tested in #5842.