Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLIP 6321] Remove Semantic UI from CMSUI #6522

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[PLIP 6321] Remove Semantic UI from CMSUI #6522

wants to merge 3 commits into from

Conversation

sneridagh
Copy link
Member

No description provided.

@netlify Netlify
Copy link

netlify bot commented Dec 8, 2024 •
edited
Loading

✅ Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit e465a2e
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/6755a775b7c5f400087dd880

@sneridagh sneridagh linked an issue Dec 8, 2024 that may be closed by this pull request
Remove Semantic UI from CMSUI #6321
Open
stevepiercy
stevepiercy requested changes Dec 8, 2024
View reviewed changes
Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this was a copy-paste job, but if it was, it would be good to paste this back to the origin.

PLIPs.md Outdated Show resolved Hide resolved
PLIPs.md Outdated Show resolved Hide resolved
PLIPs.md Outdated Show resolved Hide resolved
PLIPs.md Outdated Show resolved Hide resolved
PLIPs.md Outdated Show resolved Hide resolved
PLIPs.md Outdated Show resolved Hide resolved
PLIPs.md Outdated Show resolved Hide resolved
PLIPs.md Outdated Show resolved Hide resolved
@sneridagh
Copy link
Member Author

Not sure if this was a copy-paste job, but if it was, it would be good to paste this back to the origin.

You offend me! It's all of my doing! hahahaha

davisagli
davisagli requested changes Dec 10, 2024
View reviewed changes
Copy link
Member

@davisagli davisagli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sneridagh Who is the audience for this file? In other words, who do you expect to browse the repository contents and open the file named PLIPs.md?

In other words, I don't understand why this is here instead of:

  1. info about PLIPs in general as part of the contributor docs
  2. info about PLIP 6321 in particular in Remove Semantic UI from CMSUI #6321 (let's not spread it out in multiple places!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevepiercy stevepiercy stevepiercy requested changes

@davisagli davisagli davisagli requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Semantic UI from CMSUI
3 participants
@sneridagh @davisagli @stevepiercy