Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLIP 6321] Remove Semantic UI from CMSUI #6522

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[PLIP 6321] Remove Semantic UI from CMSUI #6522

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0a7001a
Kicking off Plone 7 PLIPs directives
sneridagh Dec 8, 2024
9f0c532
Better name for the PLIP
sneridagh Dec 8, 2024
e465a2e
Apply suggestions from code review
sneridagh Dec 8, 2024
b80fd1b
Merge branch 'main' into plip6321-semanticui-free-cmsui
sneridagh Dec 12, 2024
3aac22b
Move relevant info for this PLIP to #6321
sneridagh Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions PLIPs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
# Plone Improvement Proposals (PLIPs)

For details of the PLIP process, read the following.

- [Plone Improvement Proposals (PLIPs)](https://6.docs.plone.org/contributing/core/plips.html)
- [PLIP review](https://6.docs.plone.org/contributing/core/plip-review.html)

You can also [browse the current list of open PLIPs for Volto](https://github.com/plone/volto/labels/03%20type%3A%20feature%20(plip)).

## 6321 - Remove Semantic UI from CMSUI

Link to PLIP: [Remove Semantic UI from CMSUI](https://github.com/plone/volto/issues/6321)

### Directives

This PLIP is targeted to Plone 7.
The main goal is to get rid of Semantic UI powered components in the CMSUI.
It is expected to be a long lived branch, and we probably will want some of the changes already available for the API-first story, let's make some assumptions and rules.

All Semantic UI basic, fundamental components should be replaced by their counterparts in `@plone/components`.
Every time that we find missing components, we should create them in `@plone/components` and use them in Volto components.
These components will follow the `@plone/components` best practices, including being written in TypeScript, have accessibility tests, and have a Storybook story.
We'd like to have these new components out of this PR and used right away, so let's make all the commits around them as atomic as possible so we can cherry pick them safely and push for them in the main branch.

Every new component used in the CMSUI will be transfered from Volto core to the package `@plone/cmsui`.
By doing so, we will keep track of every new "clean" component, and potentially—being able to extract them when we want—we can use them in "real" life right away.
It will help also to avoid merging hell.
When this PLIP is done, the `src/components/manage` folder should be empty (or almost empty).
Code in Volto will remain references and imports to the `@plone/cmsui` package.

Once we start, only meaningful changes in `main` in CMSUI components will be backported, again to avoid merging hell.
Loading