-
-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing for-attribute #6249
Conversation
✅ Deploy Preview for plone-components canceled.
|
@plone/volto-accessibility Needs review |
146e718
to
4936689
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notes should describe all changes. Also added some MyST markup for inline literals.
The failing changelog check is a lie, and can be ignored. See #6232. The failing tests, however, cannot be ignored and must pass. I restarted them in case it was flaky and temporary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't change the working of the widget, just adds a11y tags. Working as expected.
packages/volto/src/components/manage/Blocks/Search/components/SearchInput.jsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Gomez have a look at my issue https://github.com/plone/volto/pull/6249/files#r1716735124
4936689
to
85f08bc
Compare
Thanks @ichim-david! This is a useful comment, i removed the duplication. Changelog updated with @stevepiercy comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog is good. @ichim-david will review upon his return, or someone else can do a technical review.
@Gomez I'll work on this tomorrow as part of the Salamina sprint. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be merged now. The fix was good although I had to improve it due to how the checkbox component works
https://github.com/Semantic-Org/Semantic-UI-React/blob/master/src/modules/Checkbox/Checkbox.js#L201
By passing the id the label gets the htmlFor from the component without us needing to add it manually
We had an a11y audit, these improvements were noted.