-
-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert rename of .gitkeep for consistency #6232
Conversation
Merge after the inclusion of twisted/towncrier#622 in the next release of towncrier.
✅ Deploy Preview for plone-components canceled.
|
I would argue this work isn't ready yet given the fact that there is no release yet for towncrier and as such the changelog run fails. I also wonder if there shouldn't be a bit more info in the doc entry regarding the need for the rename to fix the towncrier which we can revert due to fix in the upstream project. I also think this link should be in the issue description, twisted/towncrier#647 it's your fix that we are waiting to be released. |
@stevepiercy It looks like there's a release of towncrier with this change available now. |
@davisagli I had the wrong link in the description. Updated. No release since 2024-07-31, so we have to wait a bit longer. I subscribed to Watch > Custom... > Releases so I will get a notification. |
@stevepiercy Ah yep, I see. I was misled by the wrong link. |
Towncrier 24.8.0 was released today, so we can merge the PR, after it passes checks. |
Towncrier is happy now. Merging. |
Merge after the inclusion of the merged PR twisted/towncrier#647, which closed twisted/towncrier#643, in the next release of towncrier.
Closes #6225.