Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert rename of .gitkeep for consistency #6232

Merged
merged 3 commits into from
Aug 23, 2024
Merged

Conversation

stevepiercy
Copy link
Collaborator

@stevepiercy stevepiercy commented Aug 4, 2024

Merge after the inclusion of the merged PR twisted/towncrier#647, which closed twisted/towncrier#643, in the next release of towncrier.

Closes #6225.

Merge after the inclusion of twisted/towncrier#622 in the next release of towncrier.
Copy link

netlify bot commented Aug 4, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit af76a62
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/66c8f42893460800087b0928

@ichim-david
Copy link
Member

I would argue this work isn't ready yet given the fact that there is no release yet for towncrier and as such the changelog run fails.

I also wonder if there shouldn't be a bit more info in the doc entry regarding the need for the rename to fix the towncrier which we can revert due to fix in the upstream project.

I also think this link should be in the issue description, twisted/towncrier#647 it's your fix that we are waiting to be released.

@stevepiercy stevepiercy self-assigned this Aug 5, 2024
@davisagli
Copy link
Member

@stevepiercy It looks like there's a release of towncrier with this change available now.

@stevepiercy
Copy link
Collaborator Author

@davisagli I had the wrong link in the description. Updated. No release since 2024-07-31, so we have to wait a bit longer. I subscribed to Watch > Custom... > Releases so I will get a notification.

@davisagli
Copy link
Member

@stevepiercy Ah yep, I see. I was misled by the wrong link.

@stevepiercy
Copy link
Collaborator Author

Towncrier 24.8.0 was released today, so we can merge the PR, after it passes checks.

@stevepiercy
Copy link
Collaborator Author

Towncrier is happy now. Merging.

@stevepiercy stevepiercy merged commit 73ebaca into main Aug 23, 2024
70 checks passed
@stevepiercy stevepiercy deleted the revert-towncrier-name branch August 23, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add .gitkeep as one of default valid filenames Add towncrier files to ignore or rename .keep
3 participants