-
Notifications
You must be signed in to change notification settings - Fork 22
Support viewer html output #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @praveenpenumaka! This is very cool and actually something we've discussed doing as well. The reason we held off is because of the nasty submodule thing being pretty nasty. So my colleague @kpal81xd updated supersplat-viewer to publish to NPM in this PR. It means we can add the viewer as an npm dependency and access the static sources in the usual manner. Would you like to update your PR with this approach so we can it merged? Alternatively I make the changes. Thanks again for this and sorry it's taken so long for me to respond. |
|
Hi @slimbuck, Thank you for the response. I was also irked about the submodule. I am glad to hear that there is a npm module instead. I can make the required changes and update the PR. Do let me know if the approach I took seems okay. ( Creating a temp file to create viewer app ) Thanks |
|
I would probably have written the file to a memory stream somehow. Writing to a file is probably also ok, but please place it in the os tmp dir using https://nodejs.org/api/os.html#ostmpdir or similar. |
e8b06a0 to
0ee7c99
Compare
|
@slimbuck Made the required changes and verifed it now. Let me know if you need me to incorporate any more changes |
|
Could you make it a togglable option to either import from side companion file (sogs or ply compressed next to the index html), or to do it the way you do and embed the raw data as base64? |
|
@jo-chemla You mean like a zip file with an index, CSS, JS, and model file? |
|
Yes, either a zip with the html/js/3dgs/css, or a directory with all these files. I just realized your addition works as a new # splat-transform input.ply output.html
splat-transform input.ply output.sog --html
|
|
@jo-chemla zip generation may take some time for me. will probably pick it up in a separate PR. One the second aspect, you should be able to generate html viewer even on sog file
Also, I think it's better if we stick to one input and one output file for now for simplicity. |
|
@slimbuck i guess the current version can be merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with some feedback.
Co-authored-by: Will Eastcott <[email protected]>
Co-authored-by: Will Eastcott <[email protected]>
Co-authored-by: Will Eastcott <[email protected]>
|
Sorry it's taken so long to get back to you @praveenpenumaka . I've pushed a few changes and I'm ready to merge - THANKS SO MUCH FOR THIS!!! <3 |
There is an option to generate a standalone viewer app from a .ply file in the Supersplat editor. I wanted to bring it to the splat-transform cli.