Skip to content

material7svg#133

Closed
PanderMusubi wants to merge 3 commits into
plantuml:masterfrom
PanderMusubi:material7
Closed

material7svg#133
PanderMusubi wants to merge 3 commits into
plantuml:masterfrom
PanderMusubi:material7

Conversation

@PanderMusubi
Copy link
Copy Markdown
Contributor

please review, do not merge yet

@PanderMusubi
Copy link
Copy Markdown
Contributor Author

PanderMusubi commented May 2, 2025

This one is also up for review.

Three question for this PR and the PR on Bootstap. For Bootstrap, I left in the fill="currentColor" but I could not get the color working via a parameter when using the sprite. Here is the same result without fill="currentColor" .

First question, how to support color via a sprite usage parameter?

Second question, if it is not possible, remore the fill="currentColor" from Bootstrap in order to decrease the file size?

Third question, the listsprits.puml gives these errors, how to fix? Or remove the listsprites.puml file?

@PanderMusubi
Copy link
Copy Markdown
Contributor Author

bootstrap1_listsprite

material7_listsprite

@arnaudroques
Copy link
Copy Markdown
Contributor

Thanks again for you work!

I've just created a branch https://github.com/plantuml/plantuml-stdlib/tree/incoming-material7 where we could work.
This will help us to answer your questions :-)

Could you change your destination branch?

Third question, the listsprits.puml gives these errors, how to fix?

The NanoParser has to be improved :-)

The issue is here:
https://github.com/plantuml/plantuml/blob/7711694c259a41c7b23494f91fdefab44042e2a1/src/main/java/net/sourceforge/plantuml/openiconic/SvgPath.java#L214C16-L214C40

In one of the sprites, there is a T directive which probably follow another T directive (which is legal). With your example, we will be able to fix it!

@PanderMusubi
Copy link
Copy Markdown
Contributor Author

Here are the latest improvements. I have run it with plantuml/plantuml@7711694 the normal example works but the listsprites gives this error

listsprite

@The-Lum The-Lum mentioned this pull request May 3, 2025
@arnaudroques arnaudroques force-pushed the master branch 3 times, most recently from dd8fc1a to 9a1d040 Compare May 4, 2025 11:24
@PanderMusubi PanderMusubi deleted the material7 branch May 4, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants