Skip to content

Bootstrap Icons 1.11.3#131

Merged
arnaudroques merged 1 commit into
plantuml:masterfrom
PanderMusubi:bootstrapicons
Apr 30, 2025
Merged

Bootstrap Icons 1.11.3#131
arnaudroques merged 1 commit into
plantuml:masterfrom
PanderMusubi:bootstrapicons

Conversation

@PanderMusubi
Copy link
Copy Markdown
Contributor

No description provided.

@The-Lum
Copy link
Copy Markdown
Collaborator

The-Lum commented Apr 30, 2025

@PanderMusubi, @arnaudroques

I'm a little lost...
Sorry for the abrupt remarks

Warning

Beware: here is a point of attention:

  • There are a lot of MA_ACCOUNT_MINUS on all the files...

It seems these functions are not linked to the sprite name...

Perhaps:

  • either factor into a common file
  • either change all the name according to the good sprite name and add sprite param.

Other remarks:

Sorry for the abrupt remarks
Regards,
Th.

@PanderMusubi
Copy link
Copy Markdown
Contributor Author

This was a first attempt. Please, unmerge it until reviews are done. Thanks.

@PanderMusubi
Copy link
Copy Markdown
Contributor Author

Or leave it.merged but do not make a new release until all the issues have been addressed.

@PanderMusubi PanderMusubi mentioned this pull request Apr 30, 2025
@arnaudroques
Copy link
Copy Markdown
Contributor

Or leave it.merged but do not make a new release until all the issues have been addressed.

Yes, don't worry.
We won't make a new release until then.

It's really not an issue: the file are manually copied to the main plantuml repo, so we can work this way.

Many thanks for your contribution!

arnaudroques added a commit that referenced this pull request May 4, 2025
* Bootstrap Icons 1.11.3 (#131)

* Auto-generated (update output with latest stdlib)

* Bootstrap Icons SVG

---------

Co-authored-by: Pander <198964+PanderMusubi@users.noreply.github.com>
Co-authored-by: arnaudroques <467517+arnaudroques@users.noreply.github.com>
Co-authored-by: Pander <pander@users.sourceforge.net>
arnaudroques added a commit that referenced this pull request May 4, 2025
* Bootstrap Icons 1.11.3 (#131)

* Auto-generated (update output with latest stdlib)

* Bootstrap Icons SVG

---------

Co-authored-by: Pander <198964+PanderMusubi@users.noreply.github.com>
Co-authored-by: arnaudroques <467517+arnaudroques@users.noreply.github.com>
Co-authored-by: Pander <pander@users.sourceforge.net>
arnaudroques pushed a commit that referenced this pull request May 4, 2025
arnaudroques added a commit that referenced this pull request May 4, 2025
* Bootstrapsvg (#135)

* Bootstrap Icons 1.11.3 (#131)

* Auto-generated (update output with latest stdlib)

* Bootstrap Icons SVG

---------

Co-authored-by: Pander <198964+PanderMusubi@users.noreply.github.com>
Co-authored-by: arnaudroques <467517+arnaudroques@users.noreply.github.com>
Co-authored-by: Pander <pander@users.sourceforge.net>

* add a link from `bootstrap` to `bootstrap1.11.3`

---------

Co-authored-by: Pander <198964+PanderMusubi@users.noreply.github.com>
Co-authored-by: arnaudroques <467517+arnaudroques@users.noreply.github.com>
Co-authored-by: Pander <pander@users.sourceforge.net>
arnaudroques added a commit that referenced this pull request May 4, 2025
* Bootstrapsvg (#135)

* Bootstrap Icons 1.11.3 (#131)

* Auto-generated (update output with latest stdlib)

* Bootstrap Icons SVG

---------

Co-authored-by: Pander <198964+PanderMusubi@users.noreply.github.com>
Co-authored-by: arnaudroques <467517+arnaudroques@users.noreply.github.com>
Co-authored-by: Pander <pander@users.sourceforge.net>

* add a link from `bootstrap` to `bootstrap1.11.3`

---------

Co-authored-by: Pander <198964+PanderMusubi@users.noreply.github.com>
Co-authored-by: arnaudroques <467517+arnaudroques@users.noreply.github.com>
Co-authored-by: Pander <pander@users.sourceforge.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants