Fixes #721, Unstage Transaction with same signer's lower nonce. #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #728 +/- ##
==========================================
+ Coverage 86.61% 86.69% +0.07%
==========================================
Files 222 222
Lines 18753 18815 +62
==========================================
+ Hits 16243 16311 +68
+ Misses 1353 1347 -6
Partials 1157 1157
|
minhoryang
force-pushed
the
issues/721
branch
2 times, most recently
from
835df4b to
fcc94fe
Compare
|
CI Failed with following reasons:
|
minhoryang
force-pushed
the
issues/721
branch
from
fcc94fe to
c659d03
Compare
dahlia
reviewed
Dec 16, 2019
…once during Append phase
minhoryang
force-pushed
the
issues/721
branch
from
c659d03 to
b6fe7e8
Compare
dahlia
approved these changes
Dec 17, 2019
earlbread
approved these changes
Dec 17, 2019
longfin
approved these changes
Dec 17, 2019
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the unstage logic when BlockChain.Append() called (from Non-miner's Swarm.AppendBlockAsync() and Miner's BlockChain.MineBlock())