Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unstage transaction when transaction with higher nonce with same signer is in received block #721

Closed
limebell opened this issue Dec 12, 2019 · 3 comments
Closed

Unstage transaction when transaction with higher nonce with same signer is in received block #721

limebell opened this issue Dec 12, 2019 · 3 comments
Assignees
@minhoryang
Labels
good first issue Good for newcomers suggestion Suggestion or feature request

Comments

@limebell
Copy link
Member

Now staged transactions are broadcasted periodically, so stale transaction should be unstaged to prevent waste of network resource.
@limebell limebell added suggestion Suggestion or feature request good first issue Good for newcomers labels Dec 12, 2019
@limebell limebell changed the title Unstage transaction when transaction with higher nonce is in received block Unstage transaction when transaction with higher nonce with same signer is in received block Dec 12, 2019
@minhoryang
Copy link
Contributor

I'll dive in this!

@minhoryang
Copy link
Contributor

minhoryang commented Dec 14, 2019 •
edited
Loading

Planning to add the check logic at the before when Swarm.ProcessTxIds calling BlockChain.StageTransactions()

@minhoryang
Copy link
Contributor

New Plan:
Add the check logic when BlockChain.Append() called (from Non-miner's Swarm.AppendBlockAsync() and Miner's BlockChain.MineBlock())

minhoryang added a commit to minhoryang/libplanet that referenced this issue Dec 14, 2019
@minhoryang
Fixes planetarium#721, Unstage Transaction with same signer's lower n…
5e47f68 
…once during Append phase
minhoryang added a commit to minhoryang/libplanet that referenced this issue Dec 14, 2019
@minhoryang
Fixes planetarium#721, Unstage Transaction with same signer's lower n…
835df4b 
…once during Append phase
minhoryang added a commit to minhoryang/libplanet that referenced this issue Dec 14, 2019
@minhoryang
Fixes planetarium#721, Unstage Transaction with same signer's lower n…
fcc94fe 
…once during Append phase
minhoryang added a commit to minhoryang/libplanet that referenced this issue Dec 15, 2019
@minhoryang
Fixes planetarium#721, Unstage Transaction with same signer's lower n…
c659d03 
…once during Append phase
longfin added a commit that referenced this issue Dec 17, 2019
@longfin
Merge pull request #728 from minhoryang/issues/721
e1f8fe7 
Fixes #721, Unstage Transaction with same signer's lower nonce.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@minhoryang minhoryang

Labels
good first issue Good for newcomers suggestion Suggestion or feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@minhoryang @limebell