Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 604 #726

Merged
merged 3 commits into from
Dec 14, 2019
Merged

Fix 604 #726

merged 3 commits into from
Dec 14, 2019

Conversation

Oaroomy
Copy link
Contributor

@Oaroomy Oaroomy commented Dec 14, 2019

Changed KademliaProtocol.BootstrapAsync exception type from SwarmException to PeerDiscoveryException.

This pr fixes #604

@moreal
Copy link
Contributor

moreal commented Dec 14, 2019

@codecov
Copy link

codecov bot commented Dec 14, 2019

Codecov Report

Merging #726 into master will increase coverage by 1.52%.
The diff coverage is 37.5%.

@@            Coverage Diff             @@
##           master     #726      +/-   ##
==========================================
+ Coverage   85.09%   86.62%   +1.52%     
==========================================
  Files         197      222      +25     
  Lines       18060    18753     +693     
==========================================
+ Hits        15368    16244     +876     
+ Misses       1541     1352     -189     
- Partials     1151     1157       +6
Impacted Files Coverage Δ
Libplanet.Tests/Net/SwarmTest.cs 95.86% <100%> (ø) ⬆️
Libplanet/Net/Protocols/PeerDiscoveryException.cs 25% <25%> (ø)
Libplanet/Net/Protocols/KademliaProtocol.cs 65.26% <50%> (-0.53%) ⬇️
....Stun.Tests/Stun/Messages/ConnectionAttemptTest.cs 100% <0%> (ø)
...Stun/Messages/ConnectionBindSuccessResponseTest.cs 100% <0%> (ø)
...Tests/Stun/Messages/AllocateSuccessResponseTest.cs 100% <0%> (ø)
...un.Tests/Stun/Messages/RefreshErrorResponseTest.cs 100% <0%> (ø)
...Stun.Tests/Stun/Attributes/MessageIntegrityTest.cs 100% <0%> (ø)
...et.Stun.Tests/Stun/Messages/AllocateRequestTest.cs 100% <0%> (ø)
... and 34 more

@limebell limebell merged commit f7cb3ee into planetarium:master Dec 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specify exception during KademliaProtocol.BootstrapAsync
5 participants