Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify exception during KademliaProtocol.BootstrapAsync #604

Closed
limebell opened this issue Oct 23, 2019 · 1 comment · Fixed by #726
Closed

Specify exception during KademliaProtocol.BootstrapAsync #604

limebell opened this issue Oct 23, 2019 · 1 comment · Fixed by #726
Assignees
@Oaroomy
Labels
good first issue Good for newcomers

Comments

@limebell
Copy link
Member

The method just throws SwarmException when "no seed are available" and "bootstrap failed". Exception should be specified for users.
@limebell limebell added the good first issue Good for newcomers label Oct 23, 2019
@Oaroomy
Copy link
Contributor

Oaroomy commented Dec 14, 2019

I'm going to work on this.

@limebell limebell changed the title Specify exception during KademliaProtocol<T>.BootstrapAsync Specify exception during KademliaProtocol.BootstrapAsync Dec 14, 2019
@Oaroomy Oaroomy mentioned this issue Dec 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Oaroomy Oaroomy

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix 604 Oaroomy/libplanet
2 participants
@limebell @Oaroomy