Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DX - Rename some tests so that the snapshots are useful for diffs in a future PR #9220

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import {
PRE_RELEASE_BROWSER_WORKFLOW_NAME,
} from "../../utils";

test("Add new starter brick", async ({
test("Add new mod and add starter bricks", async ({
page,
newPageEditorPage,
extensionId,
Expand Down Expand Up @@ -134,7 +134,7 @@ test("Add new starter brick", async ({
});
});

test("Add starter brick to mod", async ({
test("Add new mod, save, and then add starter bricks", async ({
page,
newPageEditorPage,
extensionId,
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,75 @@
kind: recipe
options:
schema:
type: object
properties: {}
uiSchema:
ui:order:
- '*'
metadata:
id: >-
@extension-e2e-test-unaffiliated/test-trigger-00000000-0000-0000-0000-000000000000-00000000-0000-0000-0000-000000000000
name: Test Trigger 00000000-0000-0000-0000-000000000000
version: 1.0.0
description: Created with the PixieBrix Page Editor
variables:
schema:
type: object
properties: {}
apiVersion: v3
definitions:
extensionPoint:
kind: extensionPoint
definition:
type: trigger
reader:
- '@pixiebrix/document-metadata'
- '@pixiebrix/document-context'
- element: '@pixiebrix/html/element'
isAvailable:
matchPatterns:
- https://pbx.vercel.app/*
urlPatterns: []
selectors: []
allFrames: true
trigger: load
background: true
reportMode: once
showErrors: true
extensionPoint2:
kind: extensionPoint
definition:
type: menuItem
reader:
- '@pixiebrix/document-metadata'
- '@pixiebrix/document-context'
- element: '@pixiebrix/html/element'
isAvailable:
matchPatterns:
- https://pbx.vercel.app/*
urlPatterns: []
selectors: []
allFrames: true
containerSelector: ul:has(> * > a:contains('navigation'))
targetMode: document
attachMode: once
position: append
template: <li><a href="#">{{{ caption }}}</a></li>
extensionPoints:
- label: Test Trigger 00000000-0000-0000-0000-000000000000
config:
action: []
id: extensionPoint
services: {}
- label: My pbx.vercel.app button
config:
caption: Action
action: []
dynamicCaption: false
onSuccess: true
synchronous: false
permissions:
origins: []
permissions: []
id: extensionPoint2
services: {}
Original file line number Diff line number Diff line change
@@ -0,0 +1,106 @@
Index: add-context-menu-starter-brick-to-mod
===================================================================
--- add-context-menu-starter-brick-to-mod
+++ add-context-menu-starter-brick-to-mod
@@ -1,75 +1,101 @@
apiVersion: v3
definitions:
extensionPoint:
definition:
background: true
isAvailable:
allFrames: true
matchPatterns:
- https://pbx.vercel.app/*
selectors: []
urlPatterns: []
reader:
- '@pixiebrix/document-metadata'
- '@pixiebrix/document-context'
- element: '@pixiebrix/html/element'
reportMode: once
showErrors: true
trigger: load
type: trigger
kind: extensionPoint
extensionPoint2:
definition:
attachMode: once
containerSelector: ul:has(> * > a:contains('navigation'))
isAvailable:
allFrames: true
matchPatterns:
- https://pbx.vercel.app/*
selectors: []
urlPatterns: []
position: append
reader:
- '@pixiebrix/document-metadata'
- '@pixiebrix/document-context'
- element: '@pixiebrix/html/element'
targetMode: document
template: <li><a href="#">{{{ caption }}}</a></li>
type: menuItem
kind: extensionPoint
+ extensionPoint3:
+ definition:
+ contexts:
+ - all
+ documentUrlPatterns:
+ - '*://*/*'
+ isAvailable:
+ allFrames: true
+ matchPatterns:
+ - '*://*/*'
+ selectors: []
+ urlPatterns: []
+ reader:
+ - '@pixiebrix/document-metadata'
+ - '@pixiebrix/document-context'
+ - element: '@pixiebrix/html/element'
+ targetMode: eventTarget
+ type: contextMenu
+ kind: extensionPoint
extensionPoints:
- config:
action: []
id: extensionPoint
label: Test Trigger 00000000-0000-0000-0000-000000000000
services: {}
- config:
action: []
caption: Action
dynamicCaption: false
onSuccess: true
synchronous: false
id: extensionPoint2
label: My pbx.vercel.app button
+ services: {}
+ - config:
+ action: []
+ onSuccess: true
+ title: Context menu item
+ id: extensionPoint3
+ label: Context menu item
permissions:
origins: []
permissions: []
services: {}
kind: recipe
metadata:
description: Created with the PixieBrix Page Editor
id: >-
@extension-e2e-test-unaffiliated/test-trigger-00000000-0000-0000-0000-000000000000-00000000-0000-0000-0000-000000000000
name: Test Trigger 00000000-0000-0000-0000-000000000000
version: 1.0.0
options:
schema:
properties: {}
type: object
uiSchema:
ui:order:
- '*'
variables:
schema:
properties: {}
type: object
Original file line number Diff line number Diff line change
@@ -0,0 +1,114 @@
Index: add-quick-bar-starter-brick-to-mod
===================================================================
--- add-quick-bar-starter-brick-to-mod
+++ add-quick-bar-starter-brick-to-mod
@@ -19,83 +19,109 @@
type: trigger
kind: extensionPoint
extensionPoint2:
definition:
attachMode: once
containerSelector: ul:has(> * > a:contains('navigation'))
isAvailable:
allFrames: true
matchPatterns:
- https://pbx.vercel.app/*
selectors: []
urlPatterns: []
position: append
reader:
- '@pixiebrix/document-metadata'
- '@pixiebrix/document-context'
- element: '@pixiebrix/html/element'
targetMode: document
template: <li><a href="#">{{{ caption }}}</a></li>
type: menuItem
kind: extensionPoint
extensionPoint3:
definition:
contexts:
- all
documentUrlPatterns:
- '*://*/*'
isAvailable:
allFrames: true
matchPatterns:
- '*://*/*'
selectors: []
urlPatterns: []
reader:
- '@pixiebrix/document-metadata'
- '@pixiebrix/document-context'
- element: '@pixiebrix/html/element'
targetMode: eventTarget
type: contextMenu
kind: extensionPoint
+ extensionPoint4:
+ definition:
+ contexts:
+ - all
+ documentUrlPatterns:
+ - '*://*/*'
+ isAvailable:
+ allFrames: true
+ matchPatterns:
+ - '*://*/*'
+ selectors: []
+ urlPatterns: []
+ reader:
+ - '@pixiebrix/document-metadata'
+ - '@pixiebrix/document-context'
+ - element: '@pixiebrix/html/element'
+ - '@pixiebrix/selection'
+ targetMode: eventTarget
+ type: quickBar
+ kind: extensionPoint
extensionPoints:
- config:
action: []
id: extensionPoint
label: Test Trigger 00000000-0000-0000-0000-000000000000
services: {}
- config:
action: []
caption: Action
dynamicCaption: false
onSuccess: true
synchronous: false
id: extensionPoint2
label: My pbx.vercel.app button
services: {}
- config:
action: []
onSuccess: true
title: Context menu item
id: extensionPoint3
label: Context menu item
+ services: {}
+ - config:
+ action: []
+ title: Quick Bar item
+ id: extensionPoint4
+ label: Quick Bar item
permissions:
origins: []
permissions: []
services: {}
kind: recipe
metadata:
description: Created with the PixieBrix Page Editor
id: >-
@extension-e2e-test-unaffiliated/test-trigger-00000000-0000-0000-0000-000000000000-00000000-0000-0000-0000-000000000000
name: Test Trigger 00000000-0000-0000-0000-000000000000
version: 1.0.0
options:
schema:
properties: {}
type: object
uiSchema:
ui:order:
- '*'
variables:
schema:
properties: {}
type: object
Loading
Loading