Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DX - Rename some tests so that the snapshots are useful for diffs in a future PR #9220

Closed
wants to merge 1 commit into from

Conversation

BLoe
Copy link
Contributor

@BLoe BLoe commented Oct 1, 2024

What does this PR do?

For more information on our expectations for the PR process, see the
code review principles doc

@BLoe BLoe self-assigned this Oct 1, 2024
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.80%. Comparing base (8318d74) to head (2c59411).
Report is 326 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9220      +/-   ##
==========================================
+ Coverage   74.24%   74.80%   +0.55%     
==========================================
  Files        1332     1366      +34     
  Lines       40817    42149    +1332     
  Branches     7634     7879     +245     
==========================================
+ Hits        30306    31530    +1224     
- Misses      10511    10619     +108     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Oct 1, 2024

Playwright test results

passed  130 passed
flaky  4 flaky
skipped  4 skipped

Details

report  Open report ↗︎
stats  138 tests across 45 suites
duration  12 minutes, 22 seconds
commit  2c59411
info  For more information on how to debug and view this report, see our readme

Flaky tests

chrome-setup › setup/affiliated.setup.ts › authenticate with affiliated user
msedge-setup › setup/unaffiliated.setup.ts › authenticate with unaffiliated user
chrome › tests/pageEditor/addNewMod.spec.ts › Add new mod, save, and then add starter bricks
msedge › tests/pageEditor/addNewMod.spec.ts › Add new mod, save, and then add starter bricks

Skipped tests

chrome › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
msedge › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
msedge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options

@BLoe
Copy link
Contributor Author

BLoe commented Oct 1, 2024

I changed my mind, this isn't worth it, I'm just going to leave the playwright test named what it is

@BLoe BLoe closed this Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant