Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#8606 refactor files in pageEditor/ directory root #8749

Merged
merged 22 commits into from
Jul 3, 2024

Conversation

mnholtz
Copy link
Collaborator

@mnholtz mnholtz commented Jul 3, 2024

What does this PR do?

  • Closes Move/reorganize root-level src/pageEditor components #8606
  • Light reorganization of the pageEditor directory structure
    • Notably the introduction of a store/ and layout/ directory
  • See commit history for a summary of what was changed
  • There are no functional changes in this PR; the 180 file change should be relatively easy to go through due to simple import diffs

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.24%. Comparing base (8318d74) to head (b5c8ff8).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8749      +/-   ##
==========================================
- Coverage   74.24%   74.24%   -0.01%     
==========================================
  Files        1332     1332              
  Lines       40817    40825       +8     
  Branches     7634     7635       +1     
==========================================
+ Hits        30306    30311       +5     
- Misses      10511    10514       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -1113,7 +1113,7 @@
"./pageEditor/panes/insert/InsertButtonPane.tsx",
"./pageEditor/panes/save/SaveDataIntegrityErrorModal.tsx",
"./pageEditor/panes/save/saveHelpers.ts",
"./pageEditor/panes/save/savingModComponentSlice.ts",
"./pageEditor/store/savingModComponent/savingModComponentSlice.ts",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I prefer a naming schema following something like:

/savingModComponent/slice or using an index /savingModComponent/index

that exports a savingModComponentSlice

Copy link

github-actions bot commented Jul 3, 2024

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

Copy link

github-actions bot commented Jul 3, 2024

Playwright test results

passed  83 passed
flaky  1 flaky
skipped  2 skipped

Details

report  Open report ↗︎
stats  86 tests across 30 suites
duration  12 minutes, 31 seconds
commit  b5c8ff8

Flaky tests

chrome › tests/regressions/welcomeStarterBricks.spec.ts › #8740: can view the starter mods on the pixiebrix.com/welcome page

Skipped tests

chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
edge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options

@mnholtz mnholtz enabled auto-merge (squash) July 3, 2024 21:03
@mnholtz mnholtz merged commit 7233420 into main Jul 3, 2024
18 checks passed
@mnholtz mnholtz deleted the feature/8606_refactor_pageeditor_root_files branch July 3, 2024 21:19
@twschiller twschiller added this to the 2.0.5 milestone Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move/reorganize root-level src/pageEditor components
3 participants