Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mod launcher show entries with icon but no title on welcome page activation #8740

Closed
twschiller opened this issue Jul 2, 2024 · 0 comments · Fixed by #8747
Closed

Mod launcher show entries with icon but no title on welcome page activation #8740

twschiller opened this issue Jul 2, 2024 · 0 comments · Fixed by #8747
Assignees
@fungairino
Labels
bug Something isn't working triage

Comments

@twschiller
Copy link
Contributor

twschiller commented Jul 2, 2024 •
edited by grahamlangford
Loading

Context

Steps to Reproduce

  1. Ensure you have a clean install of the Extension (or at least do not have any starter mods activated)
  2. Navigate to https://pixiebrix.com/welcome
  3. Open the sidebar

Actual Behavior

  • The starter mods are not fully activated/visible (see the screenshot)
  • Clicking on one of the starter mods opens a blank panel (reserved panel)

Expected Behavior

  • The starter mods successfully activate and display normally
  • If the starter mods are still activating, the mod launcher should display the mods correctly when they have finished activating
  • Potentially display the loader we use when reconnecting to a page while activation is in progress?

Screenshot

image.png
@twschiller twschiller added the bug Something isn't working label Jul 2, 2024
@twschiller twschiller changed the title Mod launcher show entry with icon but no title Mod launcher show entries with icon but no title Jul 2, 2024
@twschiller twschiller changed the title Mod launcher show entries with icon but no title Mod launcher show entries with icon but no title on welcome page activation Jul 2, 2024
@fungairino fungairino mentioned this issue Jul 2, 2024
Merged
1 task
fungairino added a commit that referenced this issue Jul 3, 2024
@fungairino
#8740 fix welcome starter mods not loading in welcome page (#8747)
f453022 
* fix welcome starter bricks not loading in welcome page

* fix unused import

* fix test

* fix test
This was referenced Jul 3, 2024
Merged
Merged
Merged
Merged
@twschiller twschiller mentioned this issue Jul 5, 2024
Closed
This was referenced Jul 6, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Sep 22, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
This was referenced Oct 1, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Draft
Merged
Open
Merged
Merged
@github-actions github-actions bot mentioned this issue Oct 8, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fungairino fungairino

Labels
bug Something isn't working triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#8740 fix welcome starter mods not loading in welcome page pixiebrix/pixiebrix-extension
2 participants
@twschiller @fungairino