Skip to content

Conversation

@nghialv
Copy link
Member

@nghialv nghialv commented Aug 12, 2020

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

TODO

The following ISSUES will be created once got merged. If you want me to skip creating the issue, you can use /todo skip command.

Details

1. Consider using piped-stats to decide piped connection status.

https://github.com/pipe-cd/pipe/blob/f476982045538c0d8cf8aea6caf67d3126be44eb/pkg/app/api/api/web_api.go#L222-L225

This was created by todo plugin since "TODO:" was found in f476982 when #592 was merged. cc: @nghialv.

Copy link
Collaborator

@pipecd-bot pipecd-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GO_LINTER

Some issues were detected while linting go source files in your changes.

return nil
}

// TODO: Consider using piped-stats to decide piped connection status.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment on exported method WebAPI.ListPipeds should be of the form "ListPipeds ..."

https://golang.org/wiki/CodeReviewComments#doc-comments

@stormcat24
Copy link
Contributor

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by stormcat24.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 20.90%. This pull request decreases coverage by -0.01%.

File Function Base Head Diff
pkg/app/api/service/webservice/service.go DeploymentConfigTemplate.HasLabel -- 100.00% +100.00%
pkg/model/piped.go Piped.RedactSensitiveData -- 0.00% +0.00%
pkg/app/api/api/web_api.go WebAPI.GetPiped 0.00% 0.00% +0.00%
pkg/app/helloworld/service/client.go NewClient 100.00% 75.00% -25.00%
pkg/app/api/api/piped_api.go PipedAPI.ReportPipedMeta 0.00% 0.00% +0.00%
pkg/app/api/api/web_api.go WebAPI.ListPipeds 0.00% 0.00% +0.00%
pkg/app/api/service/webservice/model.go MakePiped 0.00% -- +-0.00%
pkg/app/api/service/webservice/model.go DeploymentConfigTemplate.HasLabel 100.00% -- -100.00%

@pipecd-bot
Copy link
Collaborator

TEMPLATE

failed to handle template rule examples

Details
Error: unabled to push rendered files to destination

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants