Skip to content

Conversation

@gkuga
Copy link
Contributor

@gkuga gkuga commented Aug 11, 2020

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@nghialv
Copy link
Member

nghialv commented Aug 11, 2020

Test and build were failed.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 20.81%. This pull request decreases coverage by -0.07%.

File Function Base Head Diff
pkg/app/api/api/web_api.go WebAPI.getProject -- 0.00% +0.00%
pkg/app/api/service/webservice/model.go MakeProject -- 0.00% +0.00%
pkg/app/api/api/web_api.go WebAPI.GetProject 0.00% 0.00% +0.00%

@nghialv nghialv changed the title Added GetProject Implement GetProject rpc Aug 11, 2020
@nghialv
Copy link
Member

nghialv commented Aug 12, 2020

#592
こんな感じでしましょう。
モデルの再定義をしなくても良いと思います。

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 20.98%. This pull request increases coverage by 0.09%.

File Function Base Head Diff
pkg/app/api/api/web_api.go WebAPI.getProject -- 0.00% +0.00%
pkg/model/project.go Project.RedactSensitiveData -- 100.00% +100.00%
pkg/model/project.go ProjectStaticUser.RedactSensitiveData -- 100.00% +100.00%
pkg/model/project.go ProjectSingleSignOn.RedactSensitiveData -- 100.00% +100.00%
pkg/model/project.go ProjectSingleSignOn_GitHub.RedactSensitiveData -- 100.00% +100.00%
pkg/app/api/api/web_api.go WebAPI.GetProject 0.00% 0.00% +0.00%

@nghialv
Copy link
Member

nghialv commented Aug 12, 2020

Thank you.
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit a7a0bc4 into master Aug 12, 2020
@pipecd-bot pipecd-bot deleted the project branch August 12, 2020 05:16
@pipecd-bot
Copy link
Collaborator

TEMPLATE

failed to handle template rule examples

Details
Error: unabled to push rendered files to destination

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants