Skip to content

Conversation

@t-kikuc
Copy link
Member

@t-kikuc t-kikuc commented Jan 11, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes:

Does this PR introduce a user-facing change?: no

  • How are users affected by this change: no
  • Is this breaking change: no
  • How to migrate (if breaking change): no

Signed-off-by: t-kikuc <[email protected]>
@codecov
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ab76373) 30.87% compared to head (9910591) 30.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4748      +/-   ##
==========================================
- Coverage   30.87%   30.85%   -0.02%     
==========================================
  Files         222      222              
  Lines       26037    26037              
==========================================
- Hits         8039     8035       -4     
- Misses      17349    17353       +4     
  Partials      649      649              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@t-kikuc
Copy link
Member Author

t-kikuc commented Jan 11, 2024

Sorry, I missed below

Note: File service.pb.auth.go, which is generated by our protoc-gen-auth needs to be regenerated later using the updated tool/codegen image published after this PR is merged in order to pass the action/code check (I know it's quite meta 😂), will do it later by separated PR.

#4745

@t-kikuc t-kikuc closed this Jan 11, 2024
@t-kikuc t-kikuc deleted the fix-copyright-year branch February 2, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants