Skip to content

Conversation

@khanhtc1202
Copy link
Member

@khanhtc1202 khanhtc1202 commented Jan 1, 2024

What this PR does / why we need it:

We can use make update/copyright to update all our copyrights in files.
Note: File service.pb.auth.go, which is generated by our protoc-gen-auth needs to be regenerated later using the updated tool/codegen image published after this PR is merged in order to pass the action/code check (I know it's quite meta 😂), will do it later by separated PR.

Happy New Year 🐲

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

@codecov
Copy link

codecov bot commented Jan 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2802c42) 30.85% compared to head (a312252) 30.85%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4745   +/-   ##
=======================================
  Coverage   30.85%   30.85%           
=======================================
  Files         222      222           
  Lines       26037    26037           
=======================================
+ Hits         8033     8035    +2     
+ Misses      17355    17353    -2     
  Partials      649      649           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy New Year!
Thank you for updating and the great sh!

@khanhtc1202 khanhtc1202 enabled auto-merge (squash) January 1, 2024 08:56
Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy New Year 🚀

@khanhtc1202 khanhtc1202 merged commit 449844d into master Jan 3, 2024
@khanhtc1202 khanhtc1202 deleted the update-copyright branch January 3, 2024 23:29
@t-kikuc t-kikuc mentioned this pull request Jan 11, 2024
nnnkkk7 pushed a commit to nnnkkk7/pipecd that referenced this pull request Feb 1, 2024
* Update copyright header and add command to automate this

Signed-off-by: khanhtc1202 <[email protected]>

* Rename variable

Signed-off-by: khanhtc1202 <[email protected]>

* Revert copyright for auth file

Signed-off-by: khanhtc1202 <[email protected]>

---------

Signed-off-by: khanhtc1202 <[email protected]>
@github-actions github-actions bot mentioned this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants