-
Notifications
You must be signed in to change notification settings - Fork 205
Add make command to docs to install dependencies #4572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the PR! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4572 +/- ##
==========================================
+ Coverage 29.91% 29.92% +0.01%
==========================================
Files 220 220
Lines 25892 25892
==========================================
+ Hits 7745 7749 +4
+ Misses 17499 17496 -3
+ Partials 648 647 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
khanhtc1202
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch, thanks 🙌
|
@GotoRen Please sign-off your commit to make the CI passed 🙏 |
Signed-off-by: GotoRen <[email protected]>
|
I signed-off !! |
kentakozuka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🚀
Signed-off-by: GotoRen <[email protected]> Signed-off-by: moko-poi <[email protected]>
Signed-off-by: GotoRen <[email protected]>
What this PR does / why we need it:
Add dependency install command for web config to documentation.
Developers run this command before building the Control-Plane.
Which issue(s) this PR fixes:
Fixes #4546
Does this PR introduce a user-facing change?: