Skip to content

Conversation

@ren510dev
Copy link
Contributor

@ren510dev ren510dev commented Aug 28, 2023

What this PR does / why we need it:

Add dependency install command for web config to documentation.
Developers run this command before building the Control-Plane.

Which issue(s) this PR fixes:

Fixes #4546

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

@kentakozuka
Copy link
Member

Thanks for the PR!
Could you update your commit messages and add Sign-off-by information? We're following the DCO for now, and requires signing off every commits 🙏
https://pipecd.dev/docs/contribution-guidelines/contributing/#contributor-license-agreement

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.92%. Comparing base (6e9660d) to head (69109f4).
Report is 821 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4572      +/-   ##
==========================================
+ Coverage   29.91%   29.92%   +0.01%     
==========================================
  Files         220      220              
  Lines       25892    25892              
==========================================
+ Hits         7745     7749       +4     
+ Misses      17499    17496       -3     
+ Partials      648      647       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks 🙌

@khanhtc1202
Copy link
Member

@GotoRen Please sign-off your commit to make the CI passed 🙏
https://pipecd.dev/docs/contribution-guidelines/contributing/#contributor-license-agreement

@ren510dev
Copy link
Contributor Author

I signed-off !!

Copy link
Member

@kentakozuka kentakozuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🚀

@khanhtc1202 khanhtc1202 merged commit d3e748a into pipe-cd:master Aug 28, 2023
moko-poi pushed a commit to moko-poi/pipecd that referenced this pull request Nov 3, 2023
sZma5a pushed a commit to sZma5a/pipecd that referenced this pull request Nov 5, 2023
@github-actions github-actions bot mentioned this pull request Dec 1, 2023
@github-actions github-actions bot mentioned this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add the web config dependent module installation command to the Makefile

3 participants