Skip to content

Add the web config dependent module installation command to the Makefile #4546

@ren510dev

Description

@ren510dev

What would you like to be added:

I propose to add yarn install to the following Makefile.

Why is this needed:

According to this document, to install C-Plane in the local environment, make run/pipecd must be run.
However, the one-liner fails to run because there are no dependent modules in the ./web directory.

[webpack-cli] Failed to load '/Users/ren/tmp/pipecd/web/webpack.config.js' config
[webpack-cli] Error: Cannot find module 'dotenv'
Require stack:
- /Users/ren/tmp/pipecd/web/webpack.config.js
- /Users/ren/.nvm/versions/node/v20.5.0/lib/node_modules/webpack-cli/lib/webpack-cli.js
- /Users/ren/.nvm/versions/node/v20.5.0/lib/node_modules/webpack-cli/lib/bootstrap.js
- /Users/ren/.nvm/versions/node/v20.5.0/lib/node_modules/webpack-cli/bin/cli.js
- /Users/ren/.nvm/versions/node/v20.5.0/lib/node_modules/webpack/bin/webpack.js
    at Module._resolveFilename (node:internal/modules/cjs/loader:1048:15)
    at Module._load (node:internal/modules/cjs/loader:901:27)
    at Module.require (node:internal/modules/cjs/loader:1115:19)
    at require (node:internal/modules/helpers:119:18)
    at Object.<anonymous> (/Users/ren/tmp/pipecd/web/webpack.config.js:3:1)
    at Module._compile (node:internal/modules/cjs/loader:1233:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1287:10)
    at Module.load (node:internal/modules/cjs/loader:1091:32)
    at Module._load (node:internal/modules/cjs/loader:938:12)
    at Module.require (node:internal/modules/cjs/loader:1115:19) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/Users/ren/tmp/pipecd/web/webpack.config.js',
    '/Users/ren/.nvm/versions/node/v20.5.0/lib/node_modules/webpack-cli/lib/webpack-cli.js',
    '/Users/ren/.nvm/versions/node/v20.5.0/lib/node_modules/webpack-cli/lib/bootstrap.js',
    '/Users/ren/.nvm/versions/node/v20.5.0/lib/node_modules/webpack-cli/bin/cli.js',
    '/Users/ren/.nvm/versions/node/v20.5.0/lib/node_modules/webpack/bin/webpack.js'
  ]
}
error Command failed with exit code 2.

Therefore, I propose to add yarn install to the Makefile. Wdyt ?

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions