Add breaking changes note about Helm values file restriction #3744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khanhtc1202
reviewed
Jun 10, 2022
| # allowed | ||
| - values.yaml | ||
| - ./foo/bar/values.yaml | ||
| - /path/to/dir-where-application-configuration-exists/values.yaml |
Member
There was a problem hiding this comment.
Suggested change
| - /path/to/dir-where-application-configuration-exists/values.yaml | |
| - /path/to/application-configuration-dir/values.yaml |
Contributor
Author
There was a problem hiding this comment.
Rewrite it with disallowed examples 👍
khanhtc1202
reviewed
Jun 10, 2022
| - /path/to/dir-where-application-configuration-exists/values.yaml | ||
|
|
||
| # disallowed | ||
| - ../../../../path/to/dir-where-application-configuration-file-NOT-exists/values.yaml |
Member
There was a problem hiding this comment.
Suggested change
| - ../../../../path/to/dir-where-application-configuration-file-NOT-exists/values.yaml | |
| - ../../../../path/to/OTHER-application-dir-or-such/values.yaml |
khanhtc1202
reviewed
Jun 10, 2022
|
|
||
| # disallowed | ||
| - ../../../../path/to/dir-where-application-configuration-file-NOT-exists/values.yaml | ||
| - /path/to/dir-where-application-configuration-NOT-exists/values.yaml |
Member
There was a problem hiding this comment.
Suggested change
| - /path/to/dir-where-application-configuration-NOT-exists/values.yaml | |
| - /path/to/OTHER-application-dir-or-such/values.yaml |
khanhtc1202
reviewed
Jun 10, 2022
|
|
||
| According to a recently discovered [vulnerability](https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2022-24348), it reveals that the existence of a directory traversal vulnerability when an arbitrary path can be specified as the Helm values file path. | ||
|
|
||
| For this reason, PipeCD has restricted the path that can be specified as the values file path to the directory where the application configuration (i.e. `.pipecd.yaml`) exists when a local path is specified by [#3726](https://github.com/pipe-cd/pipecd/pull/3726). |
Member
There was a problem hiding this comment.
Suggested change
| For this reason, PipeCD has restricted the path that can be specified as the values file path to the directory where the application configuration (i.e. `.pipecd.yaml`) exists when a local path is specified by [#3726](https://github.com/pipe-cd/pipecd/pull/3726). | |
| For this reason, PipeCD has restricted the path that can be specified as the values file path to the directory where the application configuration exists (aka. the application directory) when a local path is specified by [#3726](https://github.com/pipe-cd/pipecd/pull/3726). |
added 2 commits
June 10, 2022 12:50
knanao
reviewed
Jun 10, 2022
|
|
||
| According to a recently discovered [vulnerability](https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2022-24348), it reveals that the existence of a directory traversal vulnerability when an arbitrary path can be specified as the Helm values file path. | ||
|
|
||
| For this reason, PipeCD has restricted the path that can be specified as the values file path to the directory where the application configuration (i.e. `.pipecd.yaml`) exists when a local path is specified by [#3726](https://github.com/pipe-cd/pipecd/pull/3726). |
Member
There was a problem hiding this comment.
Suggested change
| For this reason, PipeCD has restricted the path that can be specified as the values file path to the directory where the application configuration (i.e. `.pipecd.yaml`) exists when a local path is specified by [#3726](https://github.com/pipe-cd/pipecd/pull/3726). | |
| For this reason, PipeCD has restricted the path that can be specified as the values file path to the directory where the application configuration (i.e. `app.pipecd.yaml`) exists when a local path is specified by [#3726](https://github.com/pipe-cd/pipecd/pull/3726). |
Contributor
Author
|
Which should I adopt? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add breaking changes note about Helm values file restriction (#3726).
This is because there was an inquiry regarding the path that can be specified as a values file, and we felt it necessary to describe the specifications in more detail.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: