Skip to content

Add flag for launcher to Makefile #3742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Szarny merged 3 commits into from
Jun 9, 2022
Merged

Add flag for launcher to Makefile #3742

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d655e74
Add `run/launcher` make command
Jun 9, 2022
1b0c189
Add LAUNCHER option to `run/piped`
Jun 9, 2022
9d89402
Remove `run/launcher`
Jun 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,13 @@ stop/pipecd:
.PHONY: run/piped
run/piped: CONFIG_FILE ?=
run/piped: INSECURE ?= false
run/piped: LAUNCHER ?= false
run/piped:
ifeq ($(LAUNCHER),true)
go run cmd/launcher/main.go launcher --config-file=$(CONFIG_FILE) --insecure=$(INSECURE)
Copy link
Member

@khanhtc1202 khanhtc1202 Jun 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about making this as a part of make run/piped and control which will be run using a flag like LAUNCHER=true ?

Copy link
Contributor Author

@Szarny Szarny Jun 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add LAUNCHER flag to run/piped! 🙏

Copy link
Contributor Author

@Szarny Szarny Jun 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now we can handle which to use like make run/piped LAUNCHER={true|false}

else
go run cmd/piped/main.go piped --tools-dir=/tmp/piped-bin --config-file=$(CONFIG_FILE) --insecure=$(INSECURE)
endif

.PHONY: run/web
run/web:
Expand Down