Add flag for launcher to Makefile #3742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khanhtc1202
reviewed
Jun 9, 2022
| run/launcher: CONFIG_FILE ?= | ||
| run/launcher: INSECURE ?= false | ||
| run/launcher: | ||
| go run cmd/launcher/main.go launcher --config-file=$(CONFIG_FILE) --insecure=$(INSECURE) |
Member
There was a problem hiding this comment.
how about making this as a part of make run/piped and control which will be run using a flag like LAUNCHER=true ?
Contributor
Author
There was a problem hiding this comment.
Add LAUNCHER flag to run/piped! 🙏
Contributor
Author
There was a problem hiding this comment.
now we can handle which to use like make run/piped LAUNCHER={true|false}
Szarny
changed the title
run/launcher target to Makefile
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add
LAUNCHERflag torun/pipedto execute the launcher more easily.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: