Skip to content

Sort the application suggestion names in application filter form #3740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khanhtc1202 merged 3 commits into from
Jun 8, 2022
Merged

Sort the application suggestion names in application filter form #3740

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
28161fb
Sort the application suggestion name in application filter form
khanhtc1202 Jun 8, 2022
c432ef7
Rename
khanhtc1202 Jun 8, 2022
20c692f
Rename
khanhtc1202 Jun 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion web/src/utils/unique-array.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
export const uniqueArray = <T>(arr: Array<T>): Array<T> => [...new Set(arr)];
export const uniqueArray = <T>(arr: Array<T>): Array<T> =>
[...new Set(arr)].sort();

@nghialv nghialv Jun 8, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that you changed at the shared place.
Will this affect all places where this function is being used? Is that ok?

@khanhtc1202 khanhtc1202 Jun 8, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I confirmed that this one only is used in related places we want. And besides, having a sorted set is a good point as well, so I think it's okay to make change like this.

@nghialv nghialv Jun 8, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that how about renaming it to sortedArray to be precise.

@khanhtc1202 khanhtc1202 Jun 8, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, I rename it as sortedSet 🙆‍♀️