Sort the application suggestion names in application filter form #3740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nghialv
reviewed
Jun 8, 2022
web/src/utils/unique-array.ts
Outdated
| @@ -1 +1,2 @@ | |||
| export const uniqueArray = <T>(arr: Array<T>): Array<T> => [...new Set(arr)]; | |||
| export const uniqueArray = <T>(arr: Array<T>): Array<T> => | |||
| [...new Set(arr)].sort(); | |||
Member
There was a problem hiding this comment.
It seems that you changed at the shared place.
Will this affect all places where this function is being used? Is that ok?
Member
Author
There was a problem hiding this comment.
yes, I confirmed that this one only is used in related places we want. And besides, having a sorted set is a good point as well, so I think it's okay to make change like this.
Member
There was a problem hiding this comment.
If that how about renaming it to sortedArray to be precise.
Member
Author
There was a problem hiding this comment.
sure, I rename it as sortedSet 🙆♀️
Member
Author
|
@knanao sorry but could you re-approval this PR 🙏 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: