Add feature to restart piped via web console (gRPC) #3706
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Szarny
changed the title
Szarny
changed the title
# Conflicts: # pkg/app/server/service/pipedservice/service.pb.go # pkg/model/piped.pb.go
This was referenced Jun 1, 2022
5 tasks
Szarny
changed the title
nghialv
reviewed
Jun 1, 2022
| // to determine whether Piped should be restarted with another version or not. | ||
| string desired_version = 30; | ||
| // The flag to determine whether Piped should be restarted with current config. | ||
| bool need_restart = 31; |
Member
There was a problem hiding this comment.
@Szarny How about doing it via Command instead of via this flag?
FYI, Command is also being used for other tasks like canceling deployment, syncing a new deployment from the web console.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR includes part of #3673 changes related to gRPC and code gen.
Which issue(s) this PR fixes:
Fixes partially #3534
Does this PR introduce a user-facing change?: