Add feature to show piped config on web console #3673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Szarny
changed the title
added 7 commits
May 26, 2022 10:32
Co-authored-by: Khanh Tran <[email protected]>
Member
|
@Szarny Even though I approved this pull, we will not merge this until the version v0.32.1 can be released, so please be informed. |
Contributor
Author
/hold |
Member
|
/hold cancel |
nghialv
reviewed
Jun 1, 2022
nghialv
reviewed
Jun 1, 2022
pkg/app/piped/cmd/piped/piped.go
Outdated
Comment on lines
808
to
815
| func deepcopy(dst interface{}, src interface{}) error { | ||
| b, err := json.Marshal(src) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| return json.Unmarshal(b, dst) | ||
| } |
Member
There was a problem hiding this comment.
How about making it less generic?
For example, adding a Clone function to the config package.
func (c *Config) Clone() (*Config, error) {
}
Contributor
Author
There was a problem hiding this comment.
I implement Clone method to *PipedSpec with this commit based on the following reasons
Confighas many fields, and there are many things to consider, such as whether it is initialized or not or what kind it is, therefore, the complexity of this PR will increase if we try to implement it in this PR.- currently, there is no need to generate clones other than
PipedSpec
nghialv
reviewed
Jun 1, 2022
| if s.SecretManagement != nil { | ||
| s.SecretManagement.Mask() | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
I wish a function could iterate all fields to execute the Mask function on them.
But I understand it can be done like this for now. So it is ok.
nghialv
reviewed
Jun 1, 2022
Member
|
@Szarny Just a nit comment. After that, we can merge this. Great work! |
This was referenced Jun 1, 2022
This was referenced Jun 1, 2022
knanao
added a commit
that referenced
this pull request
Jun 2, 2022
Merged
khanhtc1202
added a commit
that referenced
this pull request
Jun 3, 2022
khanhtc1202
added a commit
that referenced
this pull request
Jun 3, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add feature to show piped config on Web UI with masked style
Which issue(s) this PR fixes:
Fixes #3649
Does this PR introduce a user-facing change?: