Skip to content

Fix small part in state.go #2841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pipecd-bot merged 5 commits into from
Nov 25, 2021
Merged

Fix small part in state.go #2841

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8a927fa
Refactor state.go
Nov 25, 2021
eb0420d
Remove break
Nov 25, 2021
7d41450
fix
Nov 25, 2021
8442fa9
fix
Nov 25, 2021
bb725fc
fix
Nov 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions pkg/app/piped/cloudprovider/kubernetes/state.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,6 +355,9 @@ func determineJobHealth(obj *unstructured.Unstructured) (status model.Kubernetes
completed = true
message = condition.Message
}
if failed {
break
}
}

switch {
Expand Down Expand Up @@ -450,7 +453,6 @@ func determineIngressHealth(obj *unstructured.Unstructured) (status model.Kubern
status = model.KubernetesResourceState_OTHER
desc = fmt.Sprintf("Unexpected error while calculating: unable to convert %T to neither %T, %T, nor %T: %v", obj, v1Ingress, betaIngress, extensionIngress, err)
return

}

func determineServiceHealth(obj *unstructured.Unstructured) (status model.KubernetesResourceState_HealthStatus, desc string) {
Expand Down Expand Up @@ -499,12 +501,11 @@ func determinePersistentVolumeHealth(obj *unstructured.Unstructured) (status mod
case corev1.VolumeBound, corev1.VolumeAvailable:
status = model.KubernetesResourceState_HEALTHY
desc = pv.Status.Message
return
default:
status = model.KubernetesResourceState_OTHER
desc = pv.Status.Message
return
}
return
}

func determinePVCHealth(obj *unstructured.Unstructured) (status model.KubernetesResourceState_HealthStatus, desc string) {
Expand Down