Skip to content

Fix small part in state.go #2841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pipecd-bot merged 5 commits into from
Nov 25, 2021
Merged

Fix small part in state.go #2841

pipecd-bot merged 5 commits into from
Nov 25, 2021

Conversation

@ono-max
Copy link
Member

@ono-max ono-max commented Nov 25, 2021

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Nov 25, 2021

COVERAGE

Code coverage for golang is 31.73%. This pull request decreases coverage by -0.11%.

File Function Base Head Diff
pkg/app/api/grpcapi/piped_api.go PipedAPI.InChainDeploymentPlannable -- 0.00% +0.00%
pkg/app/piped/cloudprovider/kubernetes/state.go determineNameSpace -- 0.00% +0.00%
pkg/config/config.go Kind.ToApplicationKind -- 100.00% +100.00%
pkg/datastore/deploymentchainstore.go deploymentChainStore.UpdateDeploymentChain -- 0.00% +0.00%
pkg/datastore/deploymentchainstore.go deploymentChainStore.GetDeploymentChain -- 0.00% +0.00%
pkg/model/deployment.go IsSuccessfullyCompletedDeployment -- 0.00% +0.00%
pkg/app/piped/trigger/trigger.go Trigger.checkRepoCandidates 0.00% 0.00% +0.00%
pkg/app/api/grpcapi/piped_api.go PipedAPI.CreateDeployment 0.00% 0.00% +0.00%
pkg/app/piped/appconfigreporter/appconfigreporter.go Reporter.readApplicationInfo 75.00% 73.33% -1.67%
pkg/app/piped/cloudprovider/kubernetes/state.go determineResourceHealth 0.00% 0.00% +0.00%
pkg/app/piped/cloudprovider/kubernetes/state.go determineJobHealth 0.00% 0.00% +0.00%
pkg/app/piped/cloudprovider/kubernetes/state.go determineServiceHealth 0.00% 0.00% +0.00%
pkg/app/piped/cloudprovider/kubernetes/state.go determinePersistentVolumeHealth 0.00% 0.00% +0.00%

nakabonne
nakabonne reviewed Nov 25, 2021
View reviewed changes
nakabonne
nakabonne reviewed Nov 25, 2021
View reviewed changes
nakabonne
nakabonne reviewed Nov 25, 2021
View reviewed changes
@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Nov 25, 2021

COVERAGE

Code coverage for golang is 31.74%. This pull request decreases coverage by -0.11%.

File Function Base Head Diff
pkg/app/api/grpcapi/piped_api.go PipedAPI.InChainDeploymentPlannable -- 0.00% +0.00%
pkg/app/piped/cloudprovider/kubernetes/state.go determineNameSpace -- 0.00% +0.00%
pkg/config/config.go Kind.ToApplicationKind -- 100.00% +100.00%
pkg/datastore/deploymentchainstore.go deploymentChainStore.UpdateDeploymentChain -- 0.00% +0.00%
pkg/datastore/deploymentchainstore.go deploymentChainStore.GetDeploymentChain -- 0.00% +0.00%
pkg/model/deployment.go IsSuccessfullyCompletedDeployment -- 0.00% +0.00%
pkg/app/piped/appconfigreporter/appconfigreporter.go Reporter.readApplicationInfo 75.00% 73.33% -1.67%
pkg/app/piped/cloudprovider/kubernetes/state.go determineResourceHealth 0.00% 0.00% +0.00%
pkg/app/piped/cloudprovider/kubernetes/state.go determineJobHealth 0.00% 0.00% +0.00%
pkg/app/piped/cloudprovider/kubernetes/state.go determineServiceHealth 0.00% 0.00% +0.00%
pkg/app/piped/cloudprovider/kubernetes/state.go determinePersistentVolumeHealth 0.00% 0.00% +0.00%
pkg/app/piped/trigger/trigger.go Trigger.checkRepoCandidates 0.00% 0.00% +0.00%
pkg/app/api/grpcapi/piped_api.go PipedAPI.CreateDeployment 0.00% 0.00% +0.00%

小野 直人 added 2 commits November 25, 2021 12:07
@ono-max ono-max requested a review from nakabonne November 25, 2021 03:08
@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Nov 25, 2021

COVERAGE

Code coverage for golang is 31.73%. This pull request decreases coverage by -0.11%.

File Function Base Head Diff
pkg/app/api/grpcapi/piped_api.go PipedAPI.InChainDeploymentPlannable -- 0.00% +0.00%
pkg/app/piped/cloudprovider/kubernetes/state.go determineNameSpace -- 0.00% +0.00%
pkg/config/config.go Kind.ToApplicationKind -- 100.00% +100.00%
pkg/datastore/deploymentchainstore.go deploymentChainStore.UpdateDeploymentChain -- 0.00% +0.00%
pkg/datastore/deploymentchainstore.go deploymentChainStore.GetDeploymentChain -- 0.00% +0.00%
pkg/model/deployment.go IsSuccessfullyCompletedDeployment -- 0.00% +0.00%
pkg/app/piped/cloudprovider/kubernetes/state.go determineJobHealth 0.00% 0.00% +0.00%
pkg/app/piped/cloudprovider/kubernetes/state.go determinePersistentVolumeHealth 0.00% 0.00% +0.00%
pkg/app/piped/trigger/trigger.go Trigger.checkRepoCandidates 0.00% 0.00% +0.00%
pkg/app/api/grpcapi/piped_api.go PipedAPI.CreateDeployment 0.00% 0.00% +0.00%
pkg/app/piped/appconfigreporter/appconfigreporter.go Reporter.readApplicationInfo 75.00% 73.33% -1.67%
pkg/app/piped/cloudprovider/kubernetes/state.go determineResourceHealth 0.00% 0.00% +0.00%

@nakabonne
Copy link
Member

nakabonne commented Nov 25, 2021

Great job 👍
/lgtm

@khanhtc1202
Copy link
Member

khanhtc1202 commented Nov 25, 2021

Well done 👍
/approve

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Nov 25, 2021

APPROVE

This pull request is APPROVED by khanhtc1202.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 517c488 into master Nov 25, 2021
@pipecd-bot pipecd-bot deleted the patch-02 branch November 25, 2021 03:42
@ono-max ono-max mentioned this pull request Nov 26, 2021
Merged
pipecd-bot pushed a commit that referenced this pull request Nov 26, 2021
Fix small part in state.go to make it consistency (#2850)
3e98bf4 
**What this PR does / why we need it**:
As #2841 (comment), it should return to prevent us from forgetting to add a return statement in the future.

**Which issue(s) this PR fixes**:

Fixes #

**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
-->
```release-note
NONE
```

This PR was merged by Kapetanios.
This was referenced Dec 1, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khanhtc1202 khanhtc1202 Awaiting requested review from khanhtc1202

@nghialv nghialv Awaiting requested review from nghialv

@nakabonne nakabonne Awaiting requested review from nakabonne

Assignees

No one assigned

Labels

approved area/piped lgtm release-note-none size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ono-max @pipecd-bot @nakabonne @khanhtc1202