Skip to content

Conversation

@nakabonne
Copy link
Member

What this PR does / why we need it:
Add a couple of panels mainly for Prometheus still in progress though.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@khanhtc1202
Copy link
Member

💹
/lgtm

@pipecd-bot pipecd-bot added the lgtm label Jul 9, 2021
@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.07%. This pull request does not change code coverage.

"title": "Incoming Request",
"uid": "3jeba3R7z",
"version": 1
"title": "Prometheus",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file name is "incoming-request" but the title is "Prometheus".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. OMG

@nakabonne
Copy link
Member Author

@nghialv Way to pick that up! Thanks. I reverted it so PTAL

@nghialv
Copy link
Member

nghialv commented Jul 9, 2021

Nice.
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.07%. This pull request does not change code coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants