Skip to content

Put Grafana dashboards in different folders #2191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pipecd-bot merged 2 commits into from
Jul 7, 2021
Merged

Put Grafana dashboards in different folders #2191

pipecd-bot merged 2 commits into from
Jul 7, 2021

Conversation

@nakabonne
Copy link
Member

@nakabonne nakabonne commented Jul 7, 2021

What this PR does / why we need it:
This PR changes Grafana settings to manage dashboards across multiple Grafana folders declaratively.

image

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot pipecd-bot requested review from khanhtc1202 and nghialv July 7, 2021 02:48
nghialv
nghialv reviewed Jul 7, 2021
View reviewed changes
manifests/pipecd/values.yaml Outdated
dashboardproviders.yaml:
apiVersion: 1
providers:
- name: 'Cluster-Stats'
Copy link
Member

@nghialv nghialv Jul 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: One vote from me to get rid of the suffix, just use Cluster, Control-Plane, Piped.

Copy link
Member Author

@nakabonne nakabonne Jul 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright. I'm gonna adopt it as I feel the same way.

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Jul 7, 2021

COVERAGE

Code coverage for golang is 32.22%. This pull request does not change code coverage.

@nghialv
Copy link
Member

nghialv commented Jul 7, 2021

I also wonder about the convention of the dashboard name.
Where should we use a plural noun or where should not. We are having Nodes, Pods but why Prometheus, Go.
So IMO, to be simple we don't use plural nouns at all.

@nakabonne
Copy link
Member Author

nakabonne commented Jul 7, 2021

So IMO, to be simple we don't use plural nouns at all.

Looks neat. I apply it as well

@nakabonne
Copy link
Member Author

nakabonne commented Jul 7, 2021

Fixed.

@nghialv
Copy link
Member

nghialv commented Jul 7, 2021

Nice.
/lgtm

@pipecd-bot pipecd-bot added the lgtm label Jul 7, 2021
@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Jul 7, 2021

COVERAGE

Code coverage for golang is 32.22%. This pull request does not change code coverage.

@khanhtc1202
Copy link
Member

khanhtc1202 commented Jul 7, 2021

🚀
/approve

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Jul 7, 2021

APPROVE

This pull request is APPROVED by khanhtc1202.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit e1c749a into master Jul 7, 2021
@pipecd-bot pipecd-bot deleted the grafana-folder branch July 7, 2021 03:36
@nakabonne nakabonne mentioned this pull request Jul 7, 2021
Merged
pipecd-bot pushed a commit that referenced this pull request Jul 7, 2021
@nakabonne
Add minimum required dashboards (#2115)
51bd77a 
**What this PR does / why we need it**:
This PR adds three Grafana dashboards.

![image](https://user-images.githubusercontent.com/19730728/124704484-1f81f680-df2f-11eb-8c04-a40be7b01aac.png)

Because all dashboards got removed due to #2191, let me merge once though I'm still in the middle of building.

**Which issue(s) this PR fixes**:

Ref #1867

**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
-->
```release-note
NONE
```

This PR was merged by Kapetanios.
@pipecd-bot pipecd-bot mentioned this pull request Jul 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nghialv nghialv nghialv left review comments

@khanhtc1202 khanhtc1202 Awaiting requested review from khanhtc1202

Assignees

No one assigned

Labels

approved area/manifests lgtm release-note-none size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nakabonne @pipecd-bot @nghialv @khanhtc1202