Add minimum required dashboards #2115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

pipecd-bot merged 25 commits into master from add-minimum-dashboards

Jul 7, 2021

Member

nakabonne commented Jun 23, 2021 •

edited

Loading

What this PR does / why we need it:
This PR adds three Grafana dashboards.

Because all dashboards got removed due to #2191, let me merge once though I'm still in the middle of building.

Which issue(s) this PR fixes:

Does this PR introduce a user-facing change?:

NONE

pipecd-bot added release-note-none size/L area/manifests labels

pipecd-bot requested review from khanhtc1202 and nghialv

June 23, 2021 06:20

Collaborator

pipecd-bot commented Jun 23, 2021

Code coverage for golang is 32.65%. This pull request does not change code coverage.

nakabonne changed the title ~~Add minimum required dashboards for RED method~~ Add minimum required panels according to RED method

Member Author

nakabonne commented Jun 23, 2021

After discussing, we will apply them.
/hold

pipecd-bot added the do-not-merge/hold label

Collaborator

pipecd-bot commented Jun 23, 2021

Code coverage for golang is 32.65%. This pull request does not change code coverage.

2 similar comments

Collaborator

pipecd-bot commented Jun 28, 2021

Code coverage for golang is 32.65%. This pull request does not change code coverage.

Collaborator

pipecd-bot commented Jun 28, 2021

Code coverage for golang is 32.65%. This pull request does not change code coverage.

pipecd-bot added size/XL and removed size/L labels

Collaborator

pipecd-bot commented Jun 30, 2021

Code coverage for golang is 32.65%. This pull request does not change code coverage.

nakabonne force-pushed the add-minimum-dashboards branch from 5289a7e to dcbec8f Compare

June 30, 2021 07:38

Collaborator

pipecd-bot commented Jun 30, 2021

Code coverage for golang is 32.61%. This pull request does not change code coverage.

1 similar comment

Collaborator

pipecd-bot commented Jun 30, 2021

Code coverage for golang is 32.61%. This pull request does not change code coverage.

nakabonne force-pushed the add-minimum-dashboards branch from 2e0e1b5 to 105ce99 Compare

July 1, 2021 01:33

Collaborator

pipecd-bot commented Jul 1, 2021

Code coverage for golang is 32.59%. This pull request does not change code coverage.

nakabonne changed the title ~~Add minimum required panels according to RED method~~ Add minimum required dashboard

Collaborator

pipecd-bot commented Jul 1, 2021

Code coverage for golang is 32.59%. This pull request does not change code coverage.

pipecd-bot added size/XXL and removed size/XL labels

Collaborator

pipecd-bot commented Jul 1, 2021

Code coverage for golang is 32.59%. This pull request does not change code coverage.

3 similar comments

Collaborator

pipecd-bot commented Jul 1, 2021

Code coverage for golang is 32.59%. This pull request does not change code coverage.

Collaborator

pipecd-bot commented Jul 1, 2021

Code coverage for golang is 32.59%. This pull request does not change code coverage.

Collaborator

pipecd-bot commented Jul 1, 2021

Code coverage for golang is 32.59%. This pull request does not change code coverage.

nakabonne force-pushed the add-minimum-dashboards branch from 15cb231 to 6bb8869 Compare

July 1, 2021 08:18

Collaborator

pipecd-bot commented Jul 1, 2021

Code coverage for golang is 32.59%. This pull request does not change code coverage.

nakabonne added 11 commits

July 7, 2021 14:20


          Update

969fed7


          Add legend


          Update

f985a9a


          Add 4xx error

8f47d25


          Add req/res bytes panes

4b966da


          Update

5a87865


          Devide into folders

fe5ebe5


          Rename directories

e25935d


          Update

ccf062c


          Rename files

7d542d6


          Allow UI Updates

cd578a6

nakabonne force-pushed the add-minimum-dashboards branch from 9fed87f to cd578a6 Compare

July 7, 2021 05:21

Collaborator

pipecd-bot commented Jul 7, 2021

The following ISSUES will be created once got merged. If you want me to skip creating the issue, you can use /todo skip command.

Details

1. Disallow to update Grafana UI from the web once got fixed

https://github.com/pipe-cd/pipe/blob/cd578a6e3f1500dfce30e9ace818eba4bbd1a9e5/manifests/pipecd/values.yaml#L385-L388

This was created by todo plugin since "TODO:" was found in `cd578a6` when #2115 was merged. cc: @nakabonne.

Collaborator

pipecd-bot commented Jul 7, 2021

Code coverage for golang is 32.21%. This pull request does not change code coverage.

nakabonne commented

View reviewed changes

manifests/pipecd/values.yaml

    
                        editable: false

                        # TODO: Disallow to update Grafana UI from the web once got fixed

                        # The following Control-Plane's one should be reverted as well.

                        allowUiUpdates: true

Member Author

nakabonne Jul 7, 2021

We can build dashboards by copying the original. But it's a bit tedious especially because of the current number of dashboards.

Member Author

nakabonne commented Jul 7, 2021

/hold cancel

pipecd-bot removed the do-not-merge/hold label

nakabonne changed the title ~~Add minimum required dashboard~~ Add minimum required dashboards

Member

nghialv commented Jul 7, 2021

/lgtm

pipecd-bot added the lgtm label

Member

khanhtc1202 commented Jul 7, 2021

🤟🤟🤟
/approve

pipecd-bot added the approved label

Collaborator

pipecd-bot commented Jul 7, 2021

This pull request is APPROVED by khanhtc1202.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

pipecd-bot merged commit 51bd77a into master

pipecd-bot deleted the add-minimum-dashboards branch

July 7, 2021 05:45

pipecd-bot mentioned this pull request

Disallow to update Grafana UI from the web once got fixed #2193

Closed

Collaborator

pipecd-bot commented Jul 7, 2021

failed to handle template rule manifests

Details

Error: unabled to render file: manifests/pipecd/grafana-dashboards/cluster/node.json, err: template: template-plugin:206: function "instance" not defined

nakabonne mentioned this pull request

Do not render json files under grafana-dashboards #2197

Merged

pipecd-bot pushed a commit that referenced this pull request


          Do not render json files under grafana-dashboards (#2197)

dd63fff

**What this PR does / why we need it**:
To avoid something like: #2115 (comment)

**Which issue(s) this PR fixes**:

Fixes #

**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
-->
```release-note
NONE
```

This PR was merged by Kapetanios.

pipecd-bot mentioned this pull request

Explicitly use string as type for key in cache package #2200

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved area/manifests lgtm release-note-none size/XXL