Skip to content

Conversation

@khanhtc1202
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #2182

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.22%. This pull request decreases coverage by -0.01%.

File Function Base Head Diff
pkg/cli/cmd.go Telemetry.PrometheusMetricsHandlerFor -- 0.00% +0.00%

@khanhtc1202
Copy link
Member Author

/hold

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.22%. This pull request decreases coverage by -0.01%.

File Function Base Head Diff
pkg/cli/cmd.go Telemetry.PrometheusMetricsHandlerFor -- 0.00% +0.00%

@khanhtc1202
Copy link
Member Author

/hold cancel

@nghialv
Copy link
Member

nghialv commented Jul 6, 2021

Nice.
/lgtm

@pipecd-bot pipecd-bot added the lgtm label Jul 6, 2021
@nakabonne
Copy link
Member

awesome
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nakabonne.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 63a7d03 into master Jul 6, 2021
@pipecd-bot pipecd-bot deleted the piped-metrics-registry branch July 6, 2021 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add piped version as label.

5 participants