Skip to content

Add PackageType as a mandatory field for creating lambda using container image #1427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pipecd-bot merged 1 commit into from
Jan 14, 2021
Merged

Add PackageType as a mandatory field for creating lambda using container image #1427

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions pkg/app/piped/cloudprovider/lambda/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,10 +74,9 @@ func (c *client) Apply(ctx context.Context, fm FunctionManifest, role string) er
Code: &lambda.FunctionCode{
ImageUri: aws.String(fm.Spec.ImageURI),
},
PackageType: aws.String("Image"),
Copy link
Member Author

@khanhtc1202 khanhtc1202 Jan 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about other use-cases when our users may want to be able to use other kinds of PackageType ( Zip or S3 object ). But currently, we only support container image packaging, so let me hard code this PackageType value here as is, and update this later when we have a plan to support a wide range of package types.

Copy link
Member

@nghialv nghialv Jan 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an internal change so I am fine about it.
👍

Role: aws.String(role),
FunctionName: aws.String(fm.Spec.Name),
Runtime: aws.String(fm.Spec.Runtime),
Handler: aws.String(fm.Spec.Handler),
}
_, err := c.client.CreateFunctionWithContext(ctx, input)
if err != nil {
Expand All @@ -89,9 +88,7 @@ func (c *client) Apply(ctx context.Context, fm FunctionManifest, role string) er
return fmt.Errorf("aws lambda service encountered an internal error: %w", err)
case lambda.ErrCodeCodeStorageExceededException:
return fmt.Errorf("total code size per account exceeded: %w", err)
case lambda.ErrCodeResourceNotFoundException:
fallthrough
case lambda.ErrCodeResourceNotReadyException:
case lambda.ErrCodeResourceNotFoundException, lambda.ErrCodeResourceNotReadyException:
return fmt.Errorf("resource error occurred: %w", err)
}
}
Expand Down