Add PackageType as a mandatory field for creating lambda using container image #1427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Code coverage for golang is
|
khanhtc1202
commented
Jan 14, 2021
| Code: &lambda.FunctionCode{ | ||
| ImageUri: aws.String(fm.Spec.ImageURI), | ||
| }, | ||
| PackageType: aws.String("Image"), |
Member
Author
There was a problem hiding this comment.
I thought about other use-cases when our users may want to be able to use other kinds of PackageType ( Zip or S3 object ). But currently, we only support container image packaging, so let me hard code this PackageType value here as is, and update this later when we have a plan to support a wide range of package types.
Member
There was a problem hiding this comment.
This is an internal change so I am fine about it.
👍
Member
|
/lgtm |
Member
|
/approve |
Collaborator
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: