Skip to content

Add deleted_at field to mark when the application was deleted #1375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pipecd-bot merged 2 commits into from
Jan 8, 2021
Merged

Add deleted_at field to mark when the application was deleted #1375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a228647
Add deleted_at field to application model
nghialv Jan 8, 2021
2a38357
Fix validation
nghialv Jan 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pkg/datastore/applicationstore.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,10 +94,12 @@ func (s *applicationStore) DisableApplication(ctx context.Context, id string) er

func (s *applicationStore) DeleteApplication(ctx context.Context, id string) error {
return s.ds.Update(ctx, applicationModelKind, id, applicationFactory, func(e interface{}) error {
now := s.nowFunc().Unix()
app := e.(*model.Application)
app.Deleted = true
app.Disabled = true
app.UpdatedAt = s.nowFunc().Unix()
app.DeletedAt = now
app.UpdatedAt = now
return nil
})
}
Expand Down
2 changes: 2 additions & 0 deletions pkg/model/application.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ message Application {
// Current sync state.
ApplicationSyncState sync_state = 13;

// Unix time when the application was deleted.
int64 deleted_at = 98 [(validate.rules).int64.gte = 0];
// Whether the application is deleted or not.
bool deleted = 99;
// Whether the application is disabled or not.
Expand Down