Skip to content

Conversation

@nghialv
Copy link
Member

@nghialv nghialv commented Jan 8, 2021

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1374

Does this PR introduce a user-facing change?:

NONE

@nghialv nghialv changed the title Add deleted_at field to application model Add deleted_at field to mark when the application was deleted Jan 8, 2021
@nakabonne
Copy link
Member

Test failed

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 33.81%. This pull request decreases coverage by -0.01%.

File Function Base Head Diff
pkg/datastore/applicationstore.go applicationStore.DeleteApplication 0.00% 0.00% +0.00%

Copy link
Member

@nakabonne nakabonne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nakabonne.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 2b63887 into master Jan 8, 2021
@pipecd-bot pipecd-bot deleted the app-model branch January 8, 2021 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a deleted_at field to application model

4 participants