Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hold lock while writing to b.notify #303

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Conversation

edaniels
Copy link
Member

No description provided.

@edaniels edaniels requested a review from paulwe July 22, 2024 16:53
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.09%. Comparing base (e139c8a) to head (ad9bfda).

❗ There is a different number of reports uploaded between BASE (e139c8a) and HEAD (ad9bfda). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (e139c8a) HEAD (ad9bfda)
go 2 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #303       +/-   ##
===========================================
- Coverage   83.02%   65.09%   -17.93%     
===========================================
  Files          39       37        -2     
  Lines        2728     2722        -6     
===========================================
- Hits         2265     1772      -493     
- Misses        336      841      +505     
+ Partials      127      109       -18     
Flag Coverage Δ
go ?
wasm 65.09% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edaniels edaniels merged commit d55a60c into pion:master Jul 22, 2024
13 of 14 checks passed
@edaniels edaniels deleted the bcast_notify_2 branch July 22, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants