Hold lock while writing to b.notify

pion · Jul 22, 2024 · d55a60c · d55a60c
1 parent e139c8a
commit d55a60c
Showing 1 changed file with 2 additions and 8 deletions.
diff --git a/packetio/buffer.go b/packetio/buffer.go
@@ -176,14 +176,13 @@ func (b *Buffer) Write(packet []byte) (int, error) {
 	waiting := b.waiting
 	b.waiting = false
 
-	b.mutex.Unlock()
-
 	if waiting {
 		select {
 		case b.notify <- struct{}{}:
 		default:
 		}
 	}
+	b.mutex.Unlock()
 
 	return len(packet), nil
 }
@@ -280,16 +279,11 @@ func (b *Buffer) Close() (err error) {
 		return nil
 	}
 
-	waiting := b.waiting
 	b.waiting = false
 	b.closed = true
-
+	close(b.notify)
 	b.mutex.Unlock()
 
-	if waiting {
-		close(b.notify)
-	}
-
 	return nil
 }