Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple clients #32

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

binaryseed
Copy link
Contributor

I've adapted the Client to be able to start multiple GenServers. I didn't want to change the behavior of any of the other start_link functions, so there's a new function signature...

{:ok, pid} = SomeClient.start_link(thrift_client: thrift_client)

Also included is a test of this behavior, and fixes to a few Elixir 1.3 compiler warnings.

Thanks!

@coveralls
Copy link

coveralls commented Jul 19, 2016

Coverage Status

Coverage decreased (-0.05%) to 96.694% when pulling 2d317e9 on binaryseed:allow-multiple-clients into f4a4654 on pinterest:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 96.68% when pulling c6ec30d on binaryseed:allow-multiple-clients into f4a4654 on pinterest:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants