Fix Elixir 1.3 compiler warnings

pinterest · Jul 19, 2016 · 2d317e9 · 2d317e9
1 parent 14edd84
commit 2d317e9
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/lib/riffed/client.ex b/lib/riffed/client.ex
@@ -114,16 +114,16 @@ defmodule Riffed.Client do
     |> Keyword.delete(:host)
     |> Keyword.delete(:retries)
 
-    if Module.get_attribute(env.module, :auto_import_structs) do
-      struct_module = quote do
+    struct_module = if Module.get_attribute(env.module, :auto_import_structs) do
+      quote do
         defmodule unquote(struct_module) do
           use Riffed.Struct, unquote(Meta.structs_to_keyword(thrift_metadata))
           unquote_splicing(Riffed.Callbacks.reconstitute(env.module))
           unquote_splicing(Riffed.Enumeration.reconstitute(env.module))
         end
       end
     else
-      struct_module = quote do
+      quote do
       end
     end
 

diff --git a/lib/riffed/macro_helpers.ex b/lib/riffed/macro_helpers.ex
@@ -15,7 +15,7 @@ defmodule Riffed.MacroHelpers do
     |> Enum.map(&build_arg_cast(function_name, struct_module, &1, overrides, cast_function))
   end
 
-  defp build_arg({index, _type}=arg) do
+  defp build_arg({index, _type}) do
     Macro.var(:"arg_#{abs(index)}", nil)
   end
 

diff --git a/lib/riffed/server.ex b/lib/riffed/server.ex
@@ -180,8 +180,8 @@ defmodule Riffed.Server do
 
     structs_keyword = ThriftMeta.Meta.structs_to_keyword(thrift_meta)
 
-    if Module.get_attribute(env.module, :auto_import_structs)  do
-      struct_module = quote do
+    struct_module = if Module.get_attribute(env.module, :auto_import_structs)  do
+      quote do
         defmodule unquote(struct_module) do
           @build_cast_to_erlang true
           use Riffed.Struct, unquote(structs_keyword)
@@ -190,7 +190,7 @@ defmodule Riffed.Server do
         end
       end
     else
-      struct_module = quote do
+      quote do
       end
     end