Avoid use of reflection-based deserialization in Java model #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RicoYao Nice! For the setter concern it might be worth seeing what ProGuard does since it might perform that optimization for you? |
@rahul-malik will do! Also, sorry, I pushed one more commit to the PR to avoid the unnecessary usage of |
rahul-malik
approved these changes
Mar 20, 2019
Sources/Core/JavaModelRenderer.swift
Outdated
| @@ -213,6 +213,15 @@ public struct JavaModelRenderer: JavaFileRenderer { | |||
|
|
|||
| // MARK: - TypeAdapter | |||
|
|
|||
| func typeAdapterVariableNameForType(_ type: String) -> String { | |||
| return (type | |||
| .replacingOccurrences(of: "<", with: "_") | |||
There was a problem hiding this comment.
Can we refactor this logic as an extension on String? I think we do this in a couple of places throughout the codebase to convert a type to a valid variable name
There was a problem hiding this comment.
added replacingNonAlphaNumericsWith
|
@RicoYao - No worries, looks good. I'll merge when CI passes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A reflection-based adapter is not as performant. Since Plank is aware of the type of every field, it can generate a TypeAdapter for each type and route each json element in the tree to the appropriate one.
#193
Also switched to using the
Builderto generate the model, so that we don't have to manually hack the_bitsfield. We may have to revert that if we find there's a performance hit to calling setters+build instead of just setting variables directly.