Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid reflection in GSON Type Adapter #193

Closed
RicoYao opened this issue Mar 20, 2019 · 1 comment
Closed

Avoid reflection in GSON Type Adapter #193

RicoYao opened this issue Mar 20, 2019 · 1 comment
Labels
enhancement java

Comments

@RicoYao
Copy link
Contributor

RicoYao commented Mar 20, 2019 •
edited
Loading

A reflection-based adapter is not as performant. Since Plank is aware of the type of every field, it can generate a TypeAdapter that routes each json element in the tree to the pre-allocated TypeAdapter for the given type.
@RicoYao RicoYao mentioned this issue Mar 20, 2019
Merged
@RicoYao
Copy link
Contributor Author

RicoYao commented Mar 20, 2019

#194

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement java
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rahul-malik @RicoYao