Skip to content

test(orchestration): cover bounded V2 socket fallback paging - #9907

Open
saphid wants to merge 384 commits into
pingdotgg:t3code/codex-turn-mappingfrom
saphid:fix/v2-bounded-ws-fallback-20260905
Open

test(orchestration): cover bounded V2 socket fallback paging#9907
saphid wants to merge 384 commits into
pingdotgg:t3code/codex-turn-mappingfrom
saphid:fix/v2-bounded-ws-fallback-20260905

Conversation

@saphid

@saphid saphid commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Bounded socket fallbacks must preserve history cursors so clients can fetch earlier items after HTTP failure or reconnect. Julius implemented the production behavior in V2 commit 79634b140; this PR now adds regression coverage against that implementation.

Keep the current transport redaction, row budgets and legacy-client capability negotiation intact. Cover bounded snapshot metadata, schema decoding, replacing a stale cached cursor, and loading an earlier page after HTTP seeding fails.

Current head 589f12390 is rebuilt on V2 7dd9873ed with test-only prerequisite #10865 (merge first). Topic delta is four test files; no production behavior changes remain.

Validation: 95 focused server/contracts/client-runtime tests pass; all three package typechecks, targeted lint and formatting pass. New CI pending. Independent Claude Opus 5 high review unavailable: direct launcher exited 1 on expired OAuth before inference.

Targets V2 #2829. Updated with GPT-6 in Codex/T3.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Sep 5, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 589f123

Macroscope's review found this PR approvable — This PR updates only server, client-runtime, and contract tests, adding regression coverage for existing bounded socket fallback and history paging behavior. It does not modify production implementation, schemas, defaults, deployment, or static-analysis configuration.

Notes:

  • No code objects were reviewed. Approvability was decided on eligibility alone.

You can add or adjust custom eligibility rules. Learn more.

@juliusmarminge
juliusmarminge force-pushed the t3code/codex-turn-mapping branch 2 times, most recently from b82facd to 2ac9bfe Compare September 5, 2026 04:56
@saphid
saphid force-pushed the fix/v2-bounded-ws-fallback-20260905 branch from 9c7850e to fc531f1 Compare September 5, 2026 05:07
@cursor

cursor Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

@juliusmarminge
juliusmarminge force-pushed the t3code/codex-turn-mapping branch 2 times, most recently from 9242b91 to 3d81172 Compare September 8, 2026 03:31
@saphid

saphid commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

Ran an independent automated first-pass review (Amp/Astra) over the 8-file diff against 415ed0f.

  • 1 finding: bounded socket snapshots could silently degrade older V2 clients (no capability negotiation). Dismissed as false positive at high severity: the new fields are optionalKey and excess keys are dropped on decode, so legacy clients don't break; V2 is unreleased (targets feat(orchestrator): introduce new orchestrator #2829) so no shipped old-client population, and mixed nightlies already surface a version-mismatch warning. Residual: mixed-version fallback shows only the window with no load-earlier until versions sync. A negotiation/bump feels disproportionate for an unreleased branch.
  • No other findings; no code changes pushed.

juliusmarminge and others added 20 commits September 7, 2026 23:12
Cancel pending prompt completions without restarting ACP, and keep text-only monitor acknowledgements tracked as background work.

Co-authored-by: codex <codex@users.noreply.github.com>
Allow merge-back from provider-finished runs awaiting checkpoint capture while keeping waiting runs visible but non-interruptible in mobile.

Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
- Re-route steering that races completion into idempotent follow-up dispatches
- Preserve scheduled-task attribution and provider ownership history across clients
Port main's pull-request discovery, active thread ordering, async question dismissal, settlement fixes, provider-session import, attachment context, and provider correctness changes into orchestration v2.

Keep the branch's intentional composer and subagent behavior while adopting main's web and mobile fixes. Prevent headless setup terminals from hanging on the color probe, and move the v2 migration block to 050-061 after main claimed 048-049.
Restore the failed-before-start timer guard, align two server fixtures with the reconciled behavior, and remove dead files, exports, and dependencies surfaced by Knip.

Drop the temporary branch push trigger now that the PR is mergeable, so each update runs the pull-request workflow once.
Keep main's batch machine-update banner and update action while preserving the v2 runtime-based environment lock used by draft load balancing.
Adopt TypeScript 7 and Effect rc.112 across orchestration v2, including the TaggedError API migration and updated Effect-aware tests. Restore main's composer-aware scroll-to-end clearance while retaining selected-model settings sync, preview recording transfer, image galleries, desktop context menus, and layout hit targets. Regenerate the lockfile on the upgraded dependency baseline.
@juliusmarminge
juliusmarminge force-pushed the t3code/codex-turn-mapping branch from efd9994 to 6102d00 Compare September 8, 2026 06:23
juliusmarminge and others added 5 commits September 8, 2026 14:26
Advertise bounded socket snapshots and authoritative dispatch validation, omit raw command output and inline file bodies at the wire boundary, and preserve compact status metadata across web and mobile. Add transport-budget coverage for snapshots, resume, commands, legacy import, and projection maintenance.
@saphid
saphid force-pushed the fix/v2-bounded-ws-fallback-20260905 branch from 2c8b6ef to 589f123 Compare September 9, 2026 00:36
@saphid saphid changed the title fix(server): bound V2 WebSocket fallback history test(orchestration): cover bounded V2 socket fallback paging Sep 9, 2026
@github-actions github-actions Bot added size:L 100-499 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Sep 9, 2026
@juliusmarminge
juliusmarminge force-pushed the t3code/codex-turn-mapping branch from 8187b17 to ada72ce Compare September 9, 2026 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants