Skip to content

feat(mcp): expose selected environment preferences - #10560

Merged
juliusmarminge merged 2 commits into
agents/mcp-thin/previewfrom
agents/mcp-thin/preferences
Sep 7, 2026
Merged

feat(mcp): expose selected environment preferences#10560
juliusmarminge merged 2 commits into
agents/mcp-thin/previewfrom
agents/mcp-thin/preferences

Conversation

@juliusmarminge

@juliusmarminge juliusmarminge commented Sep 7, 2026

Copy link
Copy Markdown
Member

Part 10/16 of the shared-core and MCP stack. Based on #10559. Next: #10561.

Expose server identity and selected preferences, and update that allowlist through ServerSettingsService so ordinary persistence and client notifications are reused.

Updates require a live full-access/default caller under the existing ThreadCommandExecutor. Provider configuration, secrets and admin controls are not exposed. No new settings store or lock service.

MCP-only rebuild of #8726, #8728, preserving attribution to Julius Marminge's original work. Original branches remain available for separate service follow-ups.

Validation: The composed stack passes 94 tests across 12 focused files, including shared core MCP and real MCP/V2 integration, attachment intake, project RPC/service contracts, and client model command selection. Server/contracts/shared/client-runtime typechecks and targeted format/lint/diff checks pass. New behavior coverage lives with the shared operation; no per-tool mock suite was added. Current-head CI is shown below.

Layer size: 7 files, +185/-1. No domain-service production implementation or documentation files change in this MCP layer.

Prepared with Codex in the OpenAI agent runtime.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Sep 7, 2026
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

⚠️ The latest CI run did not produce a thread transfer result for d971e17.

This comment will update automatically after the next completed run.

@macroscopeapp

macroscopeapp Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR adds and registers production MCP tools, including a write operation that persists environment-wide preferences and notifies connected clients, affecting subsequent server behavior. The capability is bounded and tested, but its new cross-component workflow and externally observable settings mutation warrant human review.

No code changes detected at d971e17. Prior analysis still applies.

You can add or adjust custom eligibility rules. Learn more.

Comment thread apps/server/src/mcp/toolkits/environment/handlers.ts
@cursor

cursor Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

@juliusmarminge
juliusmarminge force-pushed the agents/mcp-thin/preferences branch from 448933e to d971e17 Compare September 7, 2026 20:55
@juliusmarminge
juliusmarminge merged commit 823d7f9 into t3code/codex-turn-mapping Sep 7, 2026
36 of 45 checks passed
@juliusmarminge
juliusmarminge deleted the agents/mcp-thin/preferences branch September 7, 2026 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant